Re: [PATCH][next] can: etas_es58x: Fix missing null check on netdev pointer

2021-04-15 Thread Marc Kleine-Budde
On 15.04.2021 20:42:36, Vincent MAILHOL wrote: > On Thu. 15 Apr 2021 at 18:04, Marc Kleine-Budde wrote: > > On 15.04.2021 09:47:23, Colin King wrote: > > > From: Colin Ian King > > > > > > There is an assignment to *netdev that is can potentially be null but the >

Re: [PATCH][next] can: etas_es58x: Fix missing null check on netdev pointer

2021-04-15 Thread Vincent MAILHOL
On Thu. 15 Apr 2021 at 18:04, Marc Kleine-Budde wrote: > On 15.04.2021 09:47:23, Colin King wrote: > > From: Colin Ian King > > > > There is an assignment to *netdev that is can potentially be null but the ^^ Typo: that is can -> that can > > null check

Re: [PATCH][next] can: etas_es58x: Fix missing null check on netdev pointer

2021-04-15 Thread Marc Kleine-Budde
On 15.04.2021 09:47:23, Colin King wrote: > From: Colin Ian King > > There is an assignment to *netdev that is can potentially be null but the > null check is checking netdev and not *netdev as intended. Fix this by > adding in the missing * operator. > > Addresses-Coverity: ("Dereference before

[PATCH][next] can: etas_es58x: Fix missing null check on netdev pointer

2021-04-15 Thread Colin King
From: Colin Ian King There is an assignment to *netdev that is can potentially be null but the null check is checking netdev and not *netdev as intended. Fix this by adding in the missing * operator. Addresses-Coverity: ("Dereference before null check") Fixes: 8537257874e9 ("can: etas_es58x: add