Re: [PATCH][next] HID: uclogic: remove redudant duplicated null check on ver_ptr

2019-03-11 Thread Benjamin Tissoires
On Sat, Mar 2, 2019 at 11:23 PM Colin King wrote: > > From: Colin Ian King > > Currently ver_ptr is being null checked twice, once before calling > usb_string and once afterwards. The second null check is redundant > and can be removed, remove it. > > Detected by CoverityScan, CID#1477308 ("Logi

[PATCH][next] HID: uclogic: remove redudant duplicated null check on ver_ptr

2019-03-02 Thread Colin King
From: Colin Ian King Currently ver_ptr is being null checked twice, once before calling usb_string and once afterwards. The second null check is redundant and can be removed, remove it. Detected by CoverityScan, CID#1477308 ("Logically dead code") Signed-off-by: Colin Ian King --- drivers/hi