Re: [PATCH][net-next] net_sched: remove redundant assignment to ret

2017-09-30 Thread David Miller
From: Colin King Date: Fri, 29 Sep 2017 15:01:16 +0100 > From: Colin Ian King > > The assignment of -EINVAL to variable ret is redundant as it > is being overwritten on the following error exit paths or > to the return value from the following call to basic_set_parms. > Fix this up by removing

Re: [PATCH][net-next] net_sched: remove redundant assignment to ret

2017-09-29 Thread Cong Wang
On Fri, Sep 29, 2017 at 7:01 AM, Colin King wrote: > From: Colin Ian King > > The assignment of -EINVAL to variable ret is redundant as it > is being overwritten on the following error exit paths or > to the return value from the following call to basic_set_parms. > Fix this up by removing it. Cl

[PATCH][net-next] net_sched: remove redundant assignment to ret

2017-09-29 Thread Colin King
From: Colin Ian King The assignment of -EINVAL to variable ret is redundant as it is being overwritten on the following error exit paths or to the return value from the following call to basic_set_parms. Fix this up by removing it. Cleans up clang warning message: net/sched/cls_basic.c:185:2: wa