Re: [PATCH][ext4-next] ext4: ensure error return ret is zero on successful return

2017-07-06 Thread Theodore Ts'o
On Fri, Jun 23, 2017 at 03:58:40PM +0100, Colin King wrote: > From: Colin Ian King > > The error return ret is not set on a successful return path and > so it returns a garbage value. Ensure it is is set to zero on > a successful return. > > Detected by CoverityScan, CID#1446616 ("Uninitialized

Re: [PATCH][ext4-next] ext4: ensure error return ret is zero on successful return

2017-06-23 Thread Tahsin Erdogan
On Fri, Jun 23, 2017 at 7:58 AM, Colin King wrote: > The error return ret is not set on a successful return path and > so it returns a garbage value. Ensure it is is set to zero on > a successful return. Thanks for catching this bug! Reviewed-by: Tahsin Erdogan

[PATCH][ext4-next] ext4: ensure error return ret is zero on successful return

2017-06-23 Thread Colin King
From: Colin Ian King The error return ret is not set on a successful return path and so it returns a garbage value. Ensure it is is set to zero on a successful return. Detected by CoverityScan, CID#1446616 ("Uninitialized scalar variable") Fixes: 3499c0fb822d ("quota: add get_inode_usage callba