Re: [PATCH][RT] 2.6.24-rc2-rt1 drivers/dma/ioat_dma.c compile fix

2007-11-20 Thread trem
Steven Rostedt wrote: > On Fri, 16 Nov 2007, Nelson, Shannon wrote: >> first->async_tx.phys; >>> - __list_splice(&new_chain, ioat_chan->used_desc.prev); >>> + list_splice_tail(&new_chain, ioat_chan->used_desc.prev); >>> >> NAK. >> >> These functions do insertions differently. The 'prev

Re: [PATCH][RT] 2.6.24-rc2-rt1 drivers/dma/ioat_dma.c compile fix

2007-11-16 Thread Nelson, Shannon
On Nov 16, 2007 3:57 AM, Sven-Thorsten Dietrich <[EMAIL PROTECTED]> wrote: > Compile fix for new code in -rc2. > > I'm not positive about the insertion point... > > Subject: compile error fix (needs review) > > RT changes __list_splice to require prev and next pointers. > > This changes the use

Re: [PATCH][RT] 2.6.24-rc2-rt1 drivers/dma/ioat_dma.c compile fix

2007-11-16 Thread Steven Rostedt
On Fri, 16 Nov 2007, Nelson, Shannon wrote: > first->async_tx.phys; > > - __list_splice(&new_chain, ioat_chan->used_desc.prev); > > + list_splice_tail(&new_chain, ioat_chan->used_desc.prev); > > > > NAK. > > These functions do insertions differently. The 'prev' is pointing to > the la

[PATCH][RT] 2.6.24-rc2-rt1 drivers/dma/ioat_dma.c compile fix

2007-11-16 Thread Sven-Thorsten Dietrich
Compile fix for new code in -rc2. I'm not positive about the insertion point... Subject: compile error fix (needs review) RT changes __list_splice to require prev and next pointers. This changes the use in the new code to list_splice_tail, but the optimal insertion point needs to be analyzed.