Re: [PATCH][RFC] x86: Fix the irq affinity in fixup_cpus

2017-07-05 Thread Chen Yu
On Wed, Jul 05, 2017 at 08:46:08AM +0200, Thomas Gleixner wrote: > On Wed, 5 Jul 2017, Chen Yu wrote: > > On Tue, Jul 04, 2017 at 10:50:33AM +0200, Thomas Gleixner wrote: > > Here's the test result for affinity: > > # uname -r > > 4.12.0+ > > # cat /proc/irq/32/smp_affinity > > ,8000 >

Re: [PATCH][RFC] x86: Fix the irq affinity in fixup_cpus

2017-07-04 Thread Thomas Gleixner
On Wed, 5 Jul 2017, Chen Yu wrote: > On Tue, Jul 04, 2017 at 10:50:33AM +0200, Thomas Gleixner wrote: > Here's the test result for affinity: > # uname -r > 4.12.0+ > # cat /proc/irq/32/smp_affinity > ,8000 > # echo 0 > /sys/devices/system/cpu/cpu31/online > # cat /proc/irq/32/smp_affin

Re: [PATCH][RFC] x86: Fix the irq affinity in fixup_cpus

2017-07-04 Thread Chen Yu
On Tue, Jul 04, 2017 at 10:50:33AM +0200, Thomas Gleixner wrote: > On Mon, 3 Jul 2017, Chen Yu wrote: > > On Sun, Jun 04, 2017 at 10:04:53PM +0200, Thomas Gleixner wrote: > > > After looking at the callsites, it's safe to change > > > irq_set_affinity_locked() so that it uses the direct affinity se

Re: [PATCH][RFC] x86: Fix the irq affinity in fixup_cpus

2017-07-04 Thread Thomas Gleixner
On Mon, 3 Jul 2017, Chen Yu wrote: > On Sun, Jun 04, 2017 at 10:04:53PM +0200, Thomas Gleixner wrote: > > After looking at the callsites, it's safe to change > > irq_set_affinity_locked() so that it uses the direct affinity setter > > function when force == true. > > > Sorry it took me sometime to

Re: [PATCH][RFC] x86: Fix the irq affinity in fixup_cpus

2017-07-03 Thread Chen Yu
On Sun, Jun 04, 2017 at 10:04:53PM +0200, Thomas Gleixner wrote: > On Mon, 24 Apr 2017, Chen Yu wrote: > > > fixup_cpus() is to set appropriate irq affinity once the CPU > > has been brought down, however we should also adjust the > > desc->irq_common_data.affinity otherwise we will get an > > inc

Re: [PATCH][RFC] x86: Fix the irq affinity in fixup_cpus

2017-06-04 Thread Thomas Gleixner
On Mon, 24 Apr 2017, Chen Yu wrote: > fixup_cpus() is to set appropriate irq affinity once the CPU > has been brought down, however we should also adjust the > desc->irq_common_data.affinity otherwise we will get an > incorrect irqmask during cpu offline: > > cat /proc/irq/31/smp_affinity > 0

[PATCH][RFC] x86: Fix the irq affinity in fixup_cpus

2017-04-24 Thread Chen Yu
fixup_cpus() is to set appropriate irq affinity once the CPU has been brought down, however we should also adjust the desc->irq_common_data.affinity otherwise we will get an incorrect irqmask during cpu offline: cat /proc/irq/31/smp_affinity ,8000 echo 0 > /sys/devices/system/cpu/cpu31