Re: [PATCH][RFC] tracing: Enable tracepoints via module parameters

2021-04-20 Thread Steven Rostedt
On Tue, 20 Apr 2021 12:54:39 -0700 Dan Williams wrote: > On Tue, Apr 20, 2021 at 5:55 AM Steven Rostedt wrote: > > > > > > The dev_dbg() filter language is attractive, it's too bad > > > > Not sure what you mean by that. What filter language. Tracepoints do have a > > pretty good filtering too

Re: [PATCH][RFC] tracing: Enable tracepoints via module parameters

2021-04-20 Thread Dan Williams
On Tue, Apr 20, 2021 at 5:55 AM Steven Rostedt wrote: [..] > > > So yes, function tracing now allows setting a filter to trace only the > > > functions for a given module, and if that module is not yet loaded, it > > > stores the filter until it is. > > > > Ah, thanks for the pointer. So if I want

Re: [PATCH][RFC] tracing: Enable tracepoints via module parameters

2021-04-20 Thread Steven Rostedt
On Tue, 20 Apr 2021 11:15:10 -0400 (EDT) Mathieu Desnoyers wrote: > That sounds fine. So that would be within the "trace_event" (and not > tracepoint) > namespace for module load parameters as well ? Right, it would be "trace_event=" not "tracepoint=..." -- Steve

Re: [PATCH][RFC] tracing: Enable tracepoints via module parameters

2021-04-20 Thread Mathieu Desnoyers
- On Apr 20, 2021, at 10:55 AM, rostedt rost...@goodmis.org wrote: > On Tue, 20 Apr 2021 09:29:27 -0400 (EDT) > Mathieu Desnoyers wrote: > >> - On Apr 20, 2021, at 8:55 AM, rostedt rost...@goodmis.org wrote: >> [...] >> > >> > Would adding automatic module parameters be an issue? That i

Re: [PATCH][RFC] tracing: Enable tracepoints via module parameters

2021-04-20 Thread Steven Rostedt
On Tue, 20 Apr 2021 09:29:27 -0400 (EDT) Mathieu Desnoyers wrote: > - On Apr 20, 2021, at 8:55 AM, rostedt rost...@goodmis.org wrote: > [...] > > > > Would adding automatic module parameters be an issue? That is, you can add > > in the insmod command line a parameter that will enable tracepo

Re: [PATCH][RFC] tracing: Enable tracepoints via module parameters

2021-04-20 Thread Mathieu Desnoyers
- On Apr 20, 2021, at 8:55 AM, rostedt rost...@goodmis.org wrote: [...] > > Would adding automatic module parameters be an issue? That is, you can add > in the insmod command line a parameter that will enable tracepoints. We > could have a way to even see them from the modinfo. I think I had t

Re: [PATCH][RFC] tracing: Enable tracepoints via module parameters

2021-04-20 Thread Steven Rostedt
On Mon, 19 Apr 2021 18:25:54 -0700 Dan Williams wrote: > On Mon, Apr 19, 2021 at 3:11 PM Steven Rostedt wrote: > > > > On Mon, 19 Apr 2021 21:54:13 + > > "Williams, Dan J" wrote: > > > > > [ drop Rusty, add Jessica and Emmanuel ] > > > > Probably could have kept Jessica on as she's the

Re: [PATCH][RFC] tracing: Enable tracepoints via module parameters

2021-04-19 Thread Dan Williams
On Mon, Apr 19, 2021 at 3:11 PM Steven Rostedt wrote: > > On Mon, 19 Apr 2021 21:54:13 + > "Williams, Dan J" wrote: > > > [ drop Rusty, add Jessica and Emmanuel ] > > Probably could have kept Jessica on as she's the module maintainer. Oh, you misread, I swapped out Rusty for Jessica on the C

Re: [PATCH][RFC] tracing: Enable tracepoints via module parameters

2021-04-19 Thread Steven Rostedt
On Mon, 19 Apr 2021 21:54:13 + "Williams, Dan J" wrote: > [ drop Rusty, add Jessica and Emmanuel ] Probably could have kept Jessica on as she's the module maintainer. > > On Wed, 2013-08-14 at 23:32 -0400, Steven Rostedt wrote: > > On Thu, 15 Aug 2013 11:32:10 +0930 Wow, this is coming ba

Re: [PATCH][RFC] tracing: Enable tracepoints via module parameters

2021-04-19 Thread Williams, Dan J
[ drop Rusty, add Jessica and Emmanuel ] On Wed, 2013-08-14 at 23:32 -0400, Steven Rostedt wrote: > On Thu, 15 Aug 2013 11:32:10 +0930 > Rusty Russell wrote: > > > Steven Rostedt writes: > > > But the thing about this that bothers me is that there's no way > > > to say, > > > "Enable all tracep

Re: [PATCH][RFC] tracing: Enable tracepoints via module parameters

2013-08-14 Thread Steven Rostedt
On Thu, 15 Aug 2013 11:32:10 +0930 Rusty Russell wrote: > Steven Rostedt writes: > > But the thing about this that bothers me is that there's no way to say, > > "Enable all tracepoints in this module on load". I would like a way to > > do that, but I don't know of a way to do that without modify

Re: [PATCH][RFC] tracing: Enable tracepoints via module parameters

2013-08-14 Thread Rusty Russell
Steven Rostedt writes: > But the thing about this that bothers me is that there's no way to say, > "Enable all tracepoints in this module on load". I would like a way to > do that, but I don't know of a way to do that without modifying the > module code. Have any ideas? Basically, I would love to

Re: [PATCH][RFC] tracing: Enable tracepoints via module parameters

2013-08-13 Thread Steven Rostedt
On Tue, 13 Aug 2013 18:34:53 -0400 Mathieu Desnoyers wrote: > What I like about this approach, if applied to kernel modules, is that > it does not require users to interact with module load parameters to > specify which tracepoints should be enabled: this is all done through > the regular tracer

Re: [PATCH][RFC] tracing: Enable tracepoints via module parameters

2013-08-13 Thread Mathieu Desnoyers
* Steven Rostedt (rost...@goodmis.org) wrote: [...] > But the thing about this that bothers me is that there's no way to say, > "Enable all tracepoints in this module on load". I would like a way to > do that, but I don't know of a way to do that without modifying the > module code. Have any ideas?

Re: [PATCH][RFC] tracing: Enable tracepoints via module parameters

2013-08-13 Thread Steven Rostedt
On Fri, 11 Mar 2011 10:03:09 +1030 Rusty Russell wrote: [ Resurrection from the dead! ] > On Tue, 08 Mar 2011 17:18:04 -0500, Steven Rostedt > wrote: > > A few months ago it was suggested to have a way to enable tracepoints in > > a module when it is loaded. I tried various methods, but this o