Re: [PATCH][RFC] perf annotate: show full line locations with 'k' in UI

2021-03-06 Thread Arnaldo Carvalho de Melo
Em Sat, Mar 06, 2021 at 08:02:24PM +0100, Martin Liška escreveu: > On 3/6/21 3:31 PM, Arnaldo Carvalho de Melo wrote: > > I see, it works only when pressing on source code lines: > > Hey. > > Yes, I forgot to explicitly mention that. Some requests, send the mail inline, not as an attachment, so

Re: [PATCH][RFC] perf annotate: show full line locations with 'k' in UI

2021-03-06 Thread Martin Liška
On 3/6/21 3:31 PM, Arnaldo Carvalho de Melo wrote: I see, it works only when pressing on source code lines: Hey. Yes, I forgot to explicitly mention that. Source file location: /usr/src/debug/kernel-5.10.fc33/linux-5.10.19-200.fc33.x86_64/./arch/x86/include/asm/msr.h:205 So we better impr

Re: [PATCH][RFC] perf annotate: show full line locations with 'k' in UI

2021-03-06 Thread Arnaldo Carvalho de Melo
Em Mon, Feb 15, 2021 at 01:34:29PM +0100, Martin Liška escreveu: > On 2/12/21 9:34 PM, Arnaldo Carvalho de Melo wrote: > > Another idea is to, when requested, reserve one line at the bottom to > > show what is the source codefile:line for where the TUI cursor is, i.e. > > you press down/up and the

Re: [PATCH][RFC] perf annotate: show full line locations with 'k' in UI

2021-02-26 Thread Martin Liška
May I please ping this? Thanks On 2/15/21 1:34 PM, Martin Liška wrote: On 2/12/21 9:34 PM, Arnaldo Carvalho de Melo wrote: Another idea is to, when requested, reserve one line at the bottom to show what is the source codefile:line  for where the TUI cursor is, i.e. you press down/up and the li

Re: [PATCH][RFC] perf annotate: show full line locations with 'k' in UI

2021-02-15 Thread Martin Liška
On 2/12/21 9:34 PM, Arnaldo Carvalho de Melo wrote: Another idea is to, when requested, reserve one line at the bottom to show what is the source codefile:line for where the TUI cursor is, i.e. you press down/up and the line under the cursor has its sourcefile:line shown at the second (from bott

Re: [PATCH][RFC] perf annotate: show full line locations with 'k' in UI

2021-02-12 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 12, 2021 at 03:42:47PM +0100, Martin Liška escreveu: > Hello. > > Sometimes it's handy to display also a filename of a source location, mainly > because > source lines can come from different files. I extended 'k' hotkey and one can > now see: > > 1) no source lines: > > 1.31 │

[PATCH][RFC] perf annotate: show full line locations with 'k' in UI

2021-02-12 Thread Martin Liška
Hello. Sometimes it's handy to display also a filename of a source location, mainly because source lines can come from different files. I extended 'k' hotkey and one can now see: 1) no source lines: 1.31 │ ↓ je 130