On Tue, Dec 19 2000, Rasmus Andersen wrote:
> On Tue, Dec 19, 2000 at 10:05:30PM +0100, Torben Mathiasen wrote:
> >
> > You should release the irq when the adapter is closed, not removed,
> > unless there's some special case that can't be handled if you take
> > ints during init.
>
> You seem to
On Tue, Dec 19, 2000 at 10:05:30PM +0100, Torben Mathiasen wrote:
>
> You should release the irq when the adapter is closed, not removed,
> unless there's some special case that can't be handled if you take
> ints during init.
You seem to be right. I have moved the free_irq to the close function
On Tue, Dec 19 2000, Francois Romieu wrote:
[deleted]
> > - if (pci_enable_device(pdev))
> > - break;
> > - pci_set_master(pdev);
> > + unregister_netdev(dev);
> > + iounmap((void *)dev->base_addr);
> > +free_irq(dev->irq, dev);
>
> I'd rather inhibit irq first then re
> > + unregister_netdev(dev);
> > + iounmap((void *)dev->base_addr);
> > +free_irq(dev->irq, dev);
>
> I'd rather inhibit irq first then release the ressources.
> + free_irq(dev->irq, dev);
> + iounmap((void *)dev->base_addr);
> + unregister_netdev(dev);
Fair enough. I
Rasmus Andersen <[EMAIL PROTECTED]> écrit :
[...]
> There are some other cleanups I want to do, and I need to make my indentation
> match the drivers, but that will be after the basic conversion is done.
>
>
> --- linux-240-t13-pre1-clean/drivers/net/rcpci45.cSat Nov 4 23:27:08 2000
> +++ l
Hi.
This is my attempt at converting the rcpci45 driver (240t13p2) to the new
PCI API interface. I fully expect to have missed something so please
comment away. BTW, I do not consider this the final version of this patch;
therefore the maintainers are not explicitly on the recipients lists.
Ther
6 matches
Mail list logo
