Re: [PATCH][BUG] Fix possible NULL pointer access in 8250 serial driver

2007-04-18 Thread Andrew Morton
On Thu, 19 Apr 2007 11:28:37 +0900 izumi <[EMAIL PROTECTED]> wrote: > Russell King wrote: > > > NAK. This means that you change the list of ports available on the > > machine to be limited to only those which are currently open. Utterly > > useless for debugging, where you normally want people

Re: [PATCH][BUG] Fix possible NULL pointer access in 8250 serial driver

2007-04-18 Thread izumi
Russell King wrote: NAK. This means that you change the list of ports available on the machine to be limited to only those which are currently open. Utterly useless for debugging, where you normally want people to dump the contents of /proc/tty/driver/*. The original patch was better. Is

Re: [PATCH][BUG] Fix possible NULL pointer access in 8250 serial driver

2007-04-18 Thread Russell King
On Wed, Apr 18, 2007 at 05:21:53PM +0900, Kenji Kaneshige wrote: > > I'd imagine that other serial drivers might get upset having their > > ->get_mcrtl() called prior to being opened. Perhaps we should be fixing > > this in uart_read_proc()? > > > > I looked at other serial drivers and I could n

Re: [PATCH][BUG] Fix possible NULL pointer access in 8250 serial driver

2007-04-18 Thread Andrew Morton
> On Wed, 18 Apr 2007 17:21:53 +0900 Kenji Kaneshige <[EMAIL PROTECTED]> wrote: > > I'd imagine that other serial drivers might get upset having their > > ->get_mcrtl() called prior to being opened. Perhaps we should be fixing > > this in uart_read_proc()? > > > > I looked at other serial driver

Re: [PATCH][BUG] Fix possible NULL pointer access in 8250 serial driver

2007-04-18 Thread Kenji Kaneshige
> I'd imagine that other serial drivers might get upset having their > ->get_mcrtl() called prior to being opened. Perhaps we should be fixing > this in uart_read_proc()? > I looked at other serial drivers and I could not find any other drivers which accesses port->info in their ->get_mctrl(). T

Re: [PATCH][BUG] Fix possible NULL pointer access in 8250 serial driver

2007-04-16 Thread Andrew Morton
On Tue, 17 Apr 2007 11:15:46 +0900 izumi <[EMAIL PROTECTED]> wrote: > Hi, > > I encountered the following kernel panic. The cause of this problem was > NULL pointer access in check_modem_status() in 8250.c. I confirmed > this problem is fixed by the attached patch, but I don't know this > is the

[PATCH][BUG] Fix possible NULL pointer access in 8250 serial driver

2007-04-16 Thread izumi
Hi, I encountered the following kernel panic. The cause of this problem was NULL pointer access in check_modem_status() in 8250.c. I confirmed this problem is fixed by the attached patch, but I don't know this is the correct fix. sadc[4378]: NaT consumption 2216203124768 [1] Modules linked in: bi