Re: [PATCH][3.10] nohz: Fix lockup on restart from wrong error code

2013-05-22 Thread Frederic Weisbecker
2013/5/22, Steven Rostedt : > On Tue, 2013-05-21 at 22:14 +0200, Frederic Weisbecker wrote: >> 2013/5/21 Steven Rostedt : >> > commit a382bf934449 "nohz: Assign timekeeping duty to a CPU outside the >> > full dynticks range" added a cpu notifier callback that would prevent >> > the time keeping CPU

Re: [PATCH][3.10] nohz: Fix lockup on restart from wrong error code

2013-05-21 Thread Steven Rostedt
On Tue, 2013-05-21 at 22:14 +0200, Frederic Weisbecker wrote: > 2013/5/21 Steven Rostedt : > > commit a382bf934449 "nohz: Assign timekeeping duty to a CPU outside the > > full dynticks range" added a cpu notifier callback that would prevent > > the time keeping CPU from going offline if the have_no

Re: [PATCH][3.10] nohz: Fix lockup on restart from wrong error code

2013-05-21 Thread Frederic Weisbecker
2013/5/21 Steven Rostedt : > commit a382bf934449 "nohz: Assign timekeeping duty to a CPU outside the > full dynticks range" added a cpu notifier callback that would prevent > the time keeping CPU from going offline if the have_nohz_full_mask was > set. > > This also prevents the CPU from going offl

Re: [PATCH][3.10] nohz: Fix lockup on restart from wrong error code

2013-05-21 Thread Frederic Weisbecker
2013/5/21 Steven Rostedt : > On Tue, 2013-05-21 at 20:12 +0200, Frederic Weisbecker wrote: > >> > Signed-off-by: Steven Rostedt >> >> There has been this patch that makes it return -EPERM instead: >> https://lkml.org/lkml/2013/5/20/386 >> >> Not sure which is best. Both sort of make sense to me. >

Re: [PATCH][3.10] nohz: Fix lockup on restart from wrong error code

2013-05-21 Thread Steven Rostedt
On Tue, 2013-05-21 at 20:12 +0200, Frederic Weisbecker wrote: > > Signed-off-by: Steven Rostedt > > There has been this patch that makes it return -EPERM instead: > https://lkml.org/lkml/2013/5/20/386 > > Not sure which is best. Both sort of make sense to me. That's just as good, as it also fi

Re: [PATCH][3.10] nohz: Fix lockup on restart from wrong error code

2013-05-21 Thread Frederic Weisbecker
2013/5/21 Steven Rostedt : > commit a382bf934449 "nohz: Assign timekeeping duty to a CPU outside the > full dynticks range" added a cpu notifier callback that would prevent > the time keeping CPU from going offline if the have_nohz_full_mask was > set. > > This also prevents the CPU from going offl

[PATCH][3.10] nohz: Fix lockup on restart from wrong error code

2013-05-21 Thread Steven Rostedt
commit a382bf934449 "nohz: Assign timekeeping duty to a CPU outside the full dynticks range" added a cpu notifier callback that would prevent the time keeping CPU from going offline if the have_nohz_full_mask was set. This also prevents the CPU from going offline on system reboot. Worse yet, the