Re: [PATCH][2.6.23-rc2-mm2] small fix for ia64 icache sync patch

2007-08-21 Thread KAMEZAWA Hiroyuki
This is updated version. Andrew, could you repleace ? -Kame == Fixing 2 small issues pointed by Tony Luck. Changelog v1 -> v2 * add pte_present_exec_user() * remove pte_user * fixed comments. v1. * removing redundant BUG_ON in __ia64_sync_icache_dcache(). * check pte_present() first. Signed-o

Re: [PATCH][2.6.23-rc2-mm2] small fix for ia64 icache sync patch

2007-08-21 Thread KAMEZAWA Hiroyuki
On Tue, 21 Aug 2007 14:12:02 -0700 "Luck, Tony" <[EMAIL PROTECTED]> wrote: > > + if (pte_present(pteval) &&// swap out ? > > + pte_exec(pteval) &&// flush only new executable page. > > pte_user(pteval) &&// ignore kernel page > > (!pte_present(*ptep) ||// do_no_page

RE: [PATCH][2.6.23-rc2-mm2] small fix for ia64 icache sync patch

2007-08-21 Thread Luck, Tony
> + if (pte_present(pteval) &&// swap out ? > + pte_exec(pteval) &&// flush only new executable page. > pte_user(pteval) &&// ignore kernel page > (!pte_present(*ptep) ||// do_no_page or swap in, migration, > pte_pfn(*ptep) != pte_pfn(pteval)))

[PATCH][2.6.23-rc2-mm2] small fix for ia64 icache sync patch

2007-08-21 Thread KAMEZAWA Hiroyuki
Fixing 2 small issues pointed by Tony Luck. * removing redundant BUG_ON in __ia64_sync_icache_dcache(). * check pte_present() first. Signed-off-by: KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> --- arch/ia64/mm/init.c|2 -- include/asm-ia64/pgtable.h |4 ++-- 2 files changed, 2 insertio