Re: [PATCH]: MTRR: fix 32-bit ioctls on x64_32

2007-01-23 Thread Giuliano Procida
On 17/01/07, H. Peter Anvin <[EMAIL PROTECTED]> wrote: Adding a case can add substantially to the generated code, especially if it makes a compact set of case labels non-compact. Is this one any better? It certainly makes for a slimmer object. Compiled, but not yet tested. Caveat patcher. Sig

Re: [PATCH]: MTRR: fix 32-bit ioctls on x64_32

2007-01-16 Thread H. Peter Anvin
Mikael Pettersson wrote: These #ifdefs are too ugly. Since you apparently just add aliases for the case labels, and do no actual code changes, why not 1. make the new cases unconditional, or 2. invoke a translation function before the switch which maps the MTRRCIOC32_ constants to what the

Re: [PATCH]: MTRR: fix 32-bit ioctls on x64_32

2007-01-16 Thread Giuliano Procida
Hi. On 16/01/07, Mikael Pettersson <[EMAIL PROTECTED]> wrote: On Tue, 16 Jan 2007 08:14:30 +, Giuliano Procida wrote: These #ifdefs are too ugly. Agreed that the #ifdefs are rather ugly, but they were the smallest change. Whoever wrote the original compat changes was relying on the IOC con

Re: [PATCH]: MTRR: fix 32-bit ioctls on x64_32

2007-01-16 Thread Mikael Pettersson
On Tue, 16 Jan 2007 08:14:30 +, Giuliano Procida wrote: > [MTRR] fix 32-bit ioctls on x64_32 > > Signed-off-by: Giuliano Procida <[EMAIL PROTECTED]> > > --- > > Fixed incomplete support for 32-bit compatibility ioctls in > 2.6.19.1. They were unhandled in one of three case-statements. > Test

[PATCH]: MTRR: fix 32-bit ioctls on x64_32

2007-01-16 Thread Giuliano Procida
[MTRR] fix 32-bit ioctls on x64_32 Signed-off-by: Giuliano Procida <[EMAIL PROTECTED]> --- Fixed incomplete support for 32-bit compatibility ioctls in 2.6.19.1. They were unhandled in one of three case-statements. Testing using X server before and after change. --- linux-source-2.6.19.1.orig/ar