Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.

2008-01-18 Thread Kumar Gala
On Jan 18, 2008, at 3:56 PM, Jochen Friedrich wrote: Hi Kumar, Ok now that makes sense, thanks So I'll ask, what serial input are you waiting for from the boot wrapper? It's the editor for the kernel command line. thanks, learn something everyday. - k -- To unsubscribe from this list:

Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.

2008-01-18 Thread Jochen Friedrich
Hi Kumar, Ok now that makes sense, thanks So I'll ask, what serial input are you waiting for from the boot wrapper? It's the editor for the kernel command line. Thanks, Jochen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTE

Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.

2008-01-18 Thread Scott Wood
Kumar Gala wrote: So I'll ask, what serial input are you waiting for from the boot wrapper? The bootwrapper has a command line editing prompt. It's fairly gratuitous in the presence of semi-decent firmware, but it's there nonetheless. -Scott -- To unsubscribe from this list: send the line

Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.

2008-01-18 Thread Kumar Gala
On Jan 18, 2008, at 2:40 PM, Alan Cox wrote: On Fri, 18 Jan 2008 19:47:43 +0100 Jochen Friedrich <[EMAIL PROTECTED]> wrote: Hi Alan, If a freescale watchdog device node is present, reset the watchdog while waiting for serial input. Why ? We normally rely on user space for watchdog managem

Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.

2008-01-18 Thread Alan Cox
On Fri, 18 Jan 2008 19:47:43 +0100 Jochen Friedrich <[EMAIL PROTECTED]> wrote: > Hi Alan, > > >> If a freescale watchdog device node is present, reset the watchdog > >> while waiting for serial input. > > > > Why ? We normally rely on user space for watchdog management as only the > > fact user

Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.

2008-01-18 Thread Jochen Friedrich
Hi Alan, If a freescale watchdog device node is present, reset the watchdog while waiting for serial input. Why ? We normally rely on user space for watchdog management as only the fact user space is behaving really proves a box is happy ? This is in the boot wrapper code, not in the linux k

Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.

2008-01-18 Thread Alan Cox
On Thu, 17 Jan 2008 13:32:35 +0100 Jochen Friedrich <[EMAIL PROTECTED]> wrote: > If a freescale watchdog device node is present, reset the watchdog > while waiting for serial input. Why ? We normally rely on user space for watchdog management as only the fact user space is behaving really proves

Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.

2008-01-18 Thread Jochen Friedrich
Scott Wood schrieb: +void watchdog_poke(void) +{ +if (wdt) { +out_be16(&wdt->swsrr, 0x556c); +out_be16(&wdt->swsrr, 0xaa39); +} +} This should be a function pointer, to allow for other watchdog types. Thanks for the comments. Stephen Rothwell also asked if the filenam

Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.

2008-01-18 Thread Scott Wood
Jochen Friedrich wrote: +void watchdog_poke(void) +{ +if (wdt) { +out_be16(&wdt->swsrr, 0x556c); +out_be16(&wdt->swsrr, 0xaa39); +} +} This should be a function pointer, to allow for other watchdog types. -Scott -- To unsubscribe from this list: send the line "unsubscri

Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.

2008-01-17 Thread Stephen Rothwell
On Thu, 17 Jan 2008 13:32:35 +0100 Jochen Friedrich <[EMAIL PROTECTED]> wrote: > > If a freescale watchdog device node is present, reset the watchdog > while waiting for serial input. > > Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> > --- > arch/powerpc/boot/Makefile |2 +- > arch/

[PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.

2008-01-17 Thread Jochen Friedrich
If a freescale watchdog device node is present, reset the watchdog while waiting for serial input. Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --- arch/powerpc/boot/Makefile |2 +- arch/powerpc/boot/cpm-serial.c |6 arch/powerpc/boot/cuboot-8xx.c |1 + arch/powerpc/boot/