Re: [PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting

2016-01-27 Thread Joonsoo Kim
On Wed, Jan 27, 2016 at 02:03:36PM +0100, Vlastimil Babka wrote: > On 01/27/2016 01:47 PM, Christian Borntraeger wrote: > > On 01/27/2016 01:41 PM, Vlastimil Babka wrote: > >> On 01/27/2016 01:59 AM, Joonsoo Kim wrote: > >> > >> I think it might be worth also to convert debug_pagealloc_enabled() t

Re: [PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting

2016-01-27 Thread Christian Borntraeger
On 01/27/2016 02:03 PM, Vlastimil Babka wrote: > On 01/27/2016 01:47 PM, Christian Borntraeger wrote: >> On 01/27/2016 01:41 PM, Vlastimil Babka wrote: >>> On 01/27/2016 01:59 AM, Joonsoo Kim wrote: >>> >>> I think it might be worth also to convert debug_pagealloc_enabled() to be >>> based >>> on

Re: [PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting

2016-01-27 Thread Vlastimil Babka
On 01/27/2016 01:47 PM, Christian Borntraeger wrote: > On 01/27/2016 01:41 PM, Vlastimil Babka wrote: >> On 01/27/2016 01:59 AM, Joonsoo Kim wrote: >> >> I think it might be worth also to convert debug_pagealloc_enabled() to be >> based >> on static key, like I did for page_owner [1]. That should

Re: [PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting

2016-01-27 Thread Christian Borntraeger
On 01/27/2016 01:41 PM, Vlastimil Babka wrote: > On 01/27/2016 01:59 AM, Joonsoo Kim wrote: >> On Tue, Jan 26, 2016 at 04:36:11PM -0800, David Rientjes wrote: >>> >>> If we can convert existing users that only check for >>> CONFIG_DEBUG_PAGEALLOC to rather check for debug_pagealloc_enabled() and

Re: [PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting

2016-01-27 Thread Vlastimil Babka
On 01/27/2016 01:59 AM, Joonsoo Kim wrote: > On Tue, Jan 26, 2016 at 04:36:11PM -0800, David Rientjes wrote: >> >> If we can convert existing users that only check for >> CONFIG_DEBUG_PAGEALLOC to rather check for debug_pagealloc_enabled() and >> agree that it is only enabled for debug_pagealloc

Re: [PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting

2016-01-27 Thread Christian Borntraeger
On 01/27/2016 01:59 AM, Joonsoo Kim wrote: > On Tue, Jan 26, 2016 at 04:36:11PM -0800, David Rientjes wrote: >> On Wed, 27 Jan 2016, Joonsoo Kim wrote: >> I'd agree if CONFIG_DEBUG_PAGEALLOC only did anything when debug_pagealloc_enabled() is true, but that doesn't seem to be the case.

Re: [PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting

2016-01-26 Thread Joonsoo Kim
On Tue, Jan 26, 2016 at 04:36:11PM -0800, David Rientjes wrote: > On Wed, 27 Jan 2016, Joonsoo Kim wrote: > > > > I'd agree if CONFIG_DEBUG_PAGEALLOC only did anything when > > > debug_pagealloc_enabled() is true, but that doesn't seem to be the case. > > > When CONFIG_DEBUG_SLAB is enabled, fo

Re: [PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting

2016-01-26 Thread David Rientjes
On Wed, 27 Jan 2016, Joonsoo Kim wrote: > > I'd agree if CONFIG_DEBUG_PAGEALLOC only did anything when > > debug_pagealloc_enabled() is true, but that doesn't seem to be the case. > > When CONFIG_DEBUG_SLAB is enabled, for instance, CONFIG_DEBUG_PAGEALLOC > > also enables stackinfo storing and

Re: [PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting

2016-01-26 Thread Joonsoo Kim
On Tue, Jan 26, 2016 at 03:29:38PM -0800, David Rientjes wrote: > On Tue, 26 Jan 2016, Heiko Carstens wrote: > > > On Tue, Jan 26, 2016 at 10:18:25AM +0100, Christian Borntraeger wrote: > > > We can use debug_pagealloc_enabled() to check if we can map > > > the identity mapping with 1MB/2GB pages

Re: [PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting

2016-01-26 Thread David Rientjes
On Tue, 26 Jan 2016, Heiko Carstens wrote: > On Tue, Jan 26, 2016 at 10:18:25AM +0100, Christian Borntraeger wrote: > > We can use debug_pagealloc_enabled() to check if we can map > > the identity mapping with 1MB/2GB pages as well as to print > > the current setting in dump_stack. > > > > Signed

Re: [PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting

2016-01-26 Thread Thomas Gleixner
On Tue, 26 Jan 2016, Heiko Carstens wrote: > On Tue, Jan 26, 2016 at 10:18:25AM +0100, Christian Borntraeger wrote: > > We can use debug_pagealloc_enabled() to check if we can map > > the identity mapping with 1MB/2GB pages as well as to print > > the current setting in dump_stack. > > > > Signed-

Re: [PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting

2016-01-26 Thread Heiko Carstens
On Tue, Jan 26, 2016 at 10:18:25AM +0100, Christian Borntraeger wrote: > We can use debug_pagealloc_enabled() to check if we can map > the identity mapping with 1MB/2GB pages as well as to print > the current setting in dump_stack. > > Signed-off-by: Christian Borntraeger > --- > arch/s390/kerne

[PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting

2016-01-26 Thread Christian Borntraeger
We can use debug_pagealloc_enabled() to check if we can map the identity mapping with 1MB/2GB pages as well as to print the current setting in dump_stack. Signed-off-by: Christian Borntraeger --- arch/s390/kernel/dumpstack.c | 4 +++- arch/s390/mm/vmem.c | 10 -- 2 files change