Re: [PATCH/RFC 1/8] leds: Add sysfs and kernel internal API for flash LEDs

2014-03-31 Thread Sakari Ailus
Hi Jacek, On Fri, Mar 28, 2014 at 04:30:19PM +0100, Jacek Anaszewski wrote: > Hi Sakari, > > Thanks for the review. > > On 03/24/2014 12:18 AM, Sakari Ailus wrote: > >Hi Jacek, > > > >Thanks for the patchset. It's very nice in general. I have a few comments > >below. > > [...] > > >>diff --git

Re: [PATCH/RFC 1/8] leds: Add sysfs and kernel internal API for flash LEDs

2014-03-28 Thread Jacek Anaszewski
Hi Sakari, Thanks for the review. On 03/24/2014 12:18 AM, Sakari Ailus wrote: Hi Jacek, Thanks for the patchset. It's very nice in general. I have a few comments below. [...] diff --git a/include/linux/leds.h b/include/linux/leds.h index 0287ab2..1bf0ab3 100644 --- a/include/linux/leds.h +

Re: [PATCH/RFC 1/8] leds: Add sysfs and kernel internal API for flash LEDs

2014-03-23 Thread Sakari Ailus
Hi Jacek, Thanks for the patchset. It's very nice in general. I have a few comments below. On Thu, Mar 20, 2014 at 03:51:03PM +0100, Jacek Anaszewski wrote: > Some LED devices support two operation modes - torch and > flash. This patch provides support for flash LED devices > in the LED subsystem

Re: [PATCH/RFC 1/8] leds: Add sysfs and kernel internal API for flash LEDs

2014-03-21 Thread Jacek Anaszewski
On 03/20/2014 04:28 PM, Richard Purdie wrote: On Thu, 2014-03-20 at 15:51 +0100, Jacek Anaszewski wrote: Some LED devices support two operation modes - torch and flash. This patch provides support for flash LED devices in the LED subsystem by introducing new sysfs attributes and kernel internal

Re: [PATCH/RFC 1/8] leds: Add sysfs and kernel internal API for flash LEDs

2014-03-20 Thread Richard Purdie
On Thu, 2014-03-20 at 15:51 +0100, Jacek Anaszewski wrote: > Some LED devices support two operation modes - torch and > flash. This patch provides support for flash LED devices > in the LED subsystem by introducing new sysfs attributes > and kernel internal interface. The attributes being > introdu

[PATCH/RFC 1/8] leds: Add sysfs and kernel internal API for flash LEDs

2014-03-20 Thread Jacek Anaszewski
Some LED devices support two operation modes - torch and flash. This patch provides support for flash LED devices in the LED subsystem by introducing new sysfs attributes and kernel internal interface. The attributes being introduced are: flash_mode, flash_timeout, max_flash_timeout, flash_fault an