Re: [PATCH/RFC] mm/debug_pagealloc: enable it by default

2016-01-25 Thread Joonsoo Kim
On Mon, Jan 25, 2016 at 08:51:56PM +0100, Christian Borntraeger wrote: > On 01/25/2016 08:38 PM, Dave Jones wrote: > > Content preview: On Mon, Jan 25, 2016 at 02:22:10PM -0500, Dave Jones > > wrote: > > > > A default mode would be ok for me as it makes things obvious. Will > > send > >

Re: [PATCH/RFC] mm/debug_pagealloc: enable it by default

2016-01-25 Thread Christian Borntraeger
On 01/25/2016 08:38 PM, Dave Jones wrote: > Content preview: On Mon, Jan 25, 2016 at 02:22:10PM -0500, Dave Jones wrote: > > > A default mode would be ok for me as it makes things obvious. Will > send > > > a patch. > > The messaging around changing a default like this was > really >

Re: [PATCH/RFC] mm/debug_pagealloc: enable it by default

2016-01-25 Thread Dave Jones
On Mon, Jan 25, 2016 at 02:22:10PM -0500, Dave Jones wrote: > > A default mode would be ok for me as it makes things obvious. Will send > > a patch. > > The messaging around changing a default like this was really poor. > When we do behaviour changes like this, we typically rename the CONF

Re: [PATCH/RFC] mm/debug_pagealloc: enable it by default

2016-01-25 Thread Dave Jones
On Mon, Jan 25, 2016 at 09:21:53AM +0100, Christian Borntraeger wrote: > >> Let's go back to the original default and reverse the command > >> line parameter to allow disabling the feature. > > > > Default disable is requested by Andrew and I agreed that. > > > > https://lkml.org/lkml/2014

Re: [PATCH/RFC] mm/debug_pagealloc: enable it by default

2016-01-25 Thread Christian Borntraeger
On 01/25/2016 07:41 AM, Joonsoo Kim wrote: > Hello, > > On Fri, Jan 22, 2016 at 12:44:40PM +0100, Christian Borntraeger wrote: >> since commit 031bc5743f158 ("mm/debug-pagealloc: make debug-pagealloc >> boottime configurable") CONFIG_DEBUG_PAGEALLOC is by default a no-op. >> >> This resulted in se

Re: [PATCH/RFC] mm/debug_pagealloc: enable it by default

2016-01-24 Thread Joonsoo Kim
Hello, On Fri, Jan 22, 2016 at 12:44:40PM +0100, Christian Borntraeger wrote: > since commit 031bc5743f158 ("mm/debug-pagealloc: make debug-pagealloc > boottime configurable") CONFIG_DEBUG_PAGEALLOC is by default a no-op. > > This resulted in several unnoticed bugs, e.g. > https://lkml.kernel.org

[PATCH/RFC] mm/debug_pagealloc: enable it by default

2016-01-22 Thread Christian Borntraeger
since commit 031bc5743f158 ("mm/debug-pagealloc: make debug-pagealloc boottime configurable") CONFIG_DEBUG_PAGEALLOC is by default a no-op. This resulted in several unnoticed bugs, e.g. https://lkml.kernel.org/g/<569f5e29.3090...@de.ibm.com> or https://lkml.kernel.org/g/<56a20f30.4050...@de.ibm.co