Re: [PART1 RFC v2 03/10] svm: Introduce new AVIC VMCB registers

2016-03-15 Thread Suravee Suthikulpanit
On 03/14/2016 07:25 PM, Paolo Bonzini wrote: On 14/03/2016 08:41, Suravee Suthikulpanit wrote: Any particular reason why you do not recommend the use of bit field? 1) The current coding style is generally not using bitfields 2) Having to review patches that change working code unrelated t

Re: [PART1 RFC v2 03/10] svm: Introduce new AVIC VMCB registers

2016-03-14 Thread Paolo Bonzini
On 14/03/2016 08:41, Suravee Suthikulpanit wrote: > Any particular reason why you do not recommend the use of bit field? 1) The current coding style is generally not using bitfields 2) Having to review patches that change working code unrelated to AVIC 3) Most of the fields are not even used w

Re: [PART1 RFC v2 03/10] svm: Introduce new AVIC VMCB registers

2016-03-14 Thread Suravee Suthikulpanit
Hi, On 03/07/2016 10:44 PM, Paolo Bonzini wrote: On 04/03/2016 21:46, Suravee Suthikulpanit wrote: >From: Suravee Suthikulpanit > >Introduce new AVIC VMCB registers. Also breakdown int_ctl register >into bit-field for ease of use. > >Signed-off-by: Suravee Suthikulpanit >--- > arch/x86/includ

Re: [PART1 RFC v2 03/10] svm: Introduce new AVIC VMCB registers

2016-03-07 Thread Paolo Bonzini
On 04/03/2016 21:46, Suravee Suthikulpanit wrote: > From: Suravee Suthikulpanit > > Introduce new AVIC VMCB registers. Also breakdown int_ctl register > into bit-field for ease of use. > > Signed-off-by: Suravee Suthikulpanit > --- > arch/x86/include/asm/svm.h | 29 --

[PART1 RFC v2 03/10] svm: Introduce new AVIC VMCB registers

2016-03-04 Thread Suravee Suthikulpanit
From: Suravee Suthikulpanit Introduce new AVIC VMCB registers. Also breakdown int_ctl register into bit-field for ease of use. Signed-off-by: Suravee Suthikulpanit --- arch/x86/include/asm/svm.h | 29 - 1 file changed, 24 insertions(+), 5 deletions(-) diff --git a/