Re: [Ocfs2-devel] [PATCH] ocfs2: give an obvious tip for dismatch cluster names

2017-05-18 Thread Gang He
Hello Joseph, >>> > Hi Gang, > > As you described, only fsdlm will return this error and fsdlm has > already print the same message. So why should we add it outside again? Yes, DLM kernel module has printed a message in this case, likes "dlm: dlm cluster name XXX mismatch YYY", then return err

Re: [Ocfs2-devel] [PATCH] ocfs2: give an obvious tip for dismatch cluster names

2017-05-18 Thread Joseph Qi
Hi Gang, As you described, only fsdlm will return this error and fsdlm has already print the same message. So why should we add it outside again? Thanks, Joseph On 17/5/18 18:43, Gang He wrote: > Hi Joseph, > > >> Hi Gang, >> >> How can we confirm EBADR is only because cluster name mismat

Re: [Ocfs2-devel] [PATCH] ocfs2: give an obvious tip for dismatch cluster names

2017-05-18 Thread Gang He
Hi Joseph, >>> > Hi Gang, > > How can we confirm EBADR is only because cluster name mismatch? > Since the cluster stack may be o2cb(o2dlm) or user(fsdlm). I looked through all the code of OCFS2 (include o2cb), there is not any place which returns this error. In fact, the function calling patch

Re: [Ocfs2-devel] [PATCH] ocfs2: give an obvious tip for dismatch cluster names

2017-05-18 Thread Joseph Qi
Hi Gang, How can we confirm EBADR is only because cluster name mismatch? Since the cluster stack may be o2cb(o2dlm) or user(fsdlm). Thanks, Joseph On 17/5/18 14:35, Gang He wrote: > This patch is used to add an obvious error message, due to > dismatch cluster names between on-disk and in the cur