[Linux-IrDA]Re: [IrDA+SMP] Lockup in handle_IRQ_event

2001-01-04 Thread Marc ZYNGIER
> "AM" == Andrew Morton <[EMAIL PROTECTED]> writes: Hi Andrew, AM> Try this: AM> --- linux-2.4.0-prerelease/net/irda/irqueue.c Tue Nov 21 20:11:22 2000 AM> +++ linux-akpm/net/irda/irqueue.c Thu Jan 4 10:14:10 2001 AM> @@ -436,7 +436,7 @@ AM> /* Release lock */ AM> if ( ha

Re: [Linux-IrDA]Re: [IrDA+SMP] Lockup in handle_IRQ_event

2001-01-04 Thread Anton Blanchard
> BTW: What i have seen in the ircomm_tty.c (2.2.18): > > 647 save_flags(flags); > 648 cli(); > 649 > 650 skb = self->tx_skb; > 651 self->tx_skb = NULL; > 652 > 653 restore_flags(flags); > > and a lot of other places simply use "save_flags(flag

Re: [Linux-IrDA]Re: [IrDA+SMP] Lockup in handle_IRQ_event

2001-01-04 Thread Keith Owens
On Thu, 4 Jan 2001 11:51:59 +0100, Florian Lohoff <[EMAIL PROTECTED]> wrote: >and a lot of other places simply use "save_flags(flags); cli(); >restore_flags()". Can someone enlighten me how this is supposed to work >on SMP machines ? AFAIK "cli()" only disables IRQs on the local >CPU so a differe

Re: [Linux-IrDA]Re: [IrDA+SMP] Lockup in handle_IRQ_event

2001-01-04 Thread Florian Lohoff
On Thu, Jan 04, 2001 at 10:18:46AM +1100, Andrew Morton wrote: > Marc ZYNGIER wrote: > > > > Hi all, > > > > Having just started playing with IrDA on my dual celeron (Abit "APIC > > error..." BP6), I managed to kill it every single time (NMI watchdog > > in handle_IRQ_event) while connecting to