Re: [Linaro-acpi] [PATCH] Mailbox: Complete wait event only if Tx was successful

2014-12-16 Thread Ashwin Chaugule
On 16 December 2014 at 06:36, Sudeep Holla wrote: > On Fri, Dec 12, 2014 at 05:47:26PM +, Ashwin Chaugule wrote: >> On 12 December 2014 at 03:43, Sudeep Holla wrote: >> > On Thursday 11 December 2014 01:46 AM, Ashwin Chaugule wrote: >> >> >> >> If a wait_for_completion_timeout() call returns

Re: [Linaro-acpi] [PATCH] Mailbox: Complete wait event only if Tx was successful

2014-12-16 Thread Sudeep Holla
On Fri, Dec 12, 2014 at 05:47:26PM +, Ashwin Chaugule wrote: > On 12 December 2014 at 03:43, Sudeep Holla wrote: > > Hi Ashwin, > > Hi, > Hi Ashwin, > > On Thursday 11 December 2014 01:46 AM, Ashwin Chaugule wrote: > >> > >> If a wait_for_completion_timeout() call returns due to a timeout,

Re: [Linaro-acpi] [PATCH] Mailbox: Complete wait event only if Tx was successful

2014-12-12 Thread Ashwin Chaugule
On 12 December 2014 at 03:43, Sudeep Holla wrote: > Hi Ashwin, Hi, > On Thursday 11 December 2014 01:46 AM, Ashwin Chaugule wrote: >> >> If a wait_for_completion_timeout() call returns due to a timeout, >> the mbox code can still call complete() after returning from the wait. >> This can cause s

Re: [Linaro-acpi] [PATCH] Mailbox: Complete wait event only if Tx was successful

2014-12-12 Thread Sudeep Holla
Hi Ashwin, On Thursday 11 December 2014 01:46 AM, Ashwin Chaugule wrote: If a wait_for_completion_timeout() call returns due to a timeout, the mbox code can still call complete() after returning from the wait. This can cause subsequent transmissions on a channel to fail, since the wait_for_compl