Re: [LKP] [mm, oom] c1e4c54f9c: BUG:KASAN:null-ptr-deref_in_d

2018-08-06 Thread David Rientjes
On Mon, 6 Aug 2018, 禹舟键 wrote: > Hi Michal > Sorry, I cannot open the link you shared. > The suggestion atop your previous patch was diff --git a/mm/oom_kill.c b/mm/oom_kill.c --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -438,14 +438,6 @@ static void dump_header(struct oom_control *oc, struct ta

Re: [LKP] [mm, oom] c1e4c54f9c: BUG:KASAN:null-ptr-deref_in_d

2018-08-06 Thread 禹舟键
Hi Michal Sorry, I cannot open the link you shared.

Re: [LKP] [mm, oom] c1e4c54f9c: BUG:KASAN:null-ptr-deref_in_d

2018-08-05 Thread Michal Hocko
On Sun 05-08-18 11:41:50, 禹舟键 wrote: > Hi Michal and David, > AFAICS, the null pointer is the task_struct of p in the dump_header. > Why don't we just add a if before printing the victim task's > informaiton. See http://lkml.kernel.org/r/alpine.deb.2.21.1807301854040.198...@chino.kir.corp.google.

Re: [LKP] [mm, oom] c1e4c54f9c: BUG:KASAN:null-ptr-deref_in_d

2018-08-04 Thread 禹舟键
Hi Michal and David, AFAICS, the null pointer is the task_struct of p in the dump_header. Why don't we just add a if before printing the victim task's informaiton. diff --git a/mm/oom_kill.c b/mm/oom_kill.c --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -438,14 +438,6 @@ static void dump_header(struct

Re: [LKP] [mm, oom] c1e4c54f9c: BUG:KASAN:null-ptr-deref_in_d

2018-07-31 Thread 基础平台部
: [LKP] [mm, oom] c1e4c54f9c: BUG:KASAN:null-ptr-deref_in_d On Mon 30-07-18 19:05:50, David Rientjes wrote: > On Mon, 30 Jul 2018, Michal Hocko wrote: > > > On Mon 30-07-18 17:03:20, kernel test robot wrote: > > [...] > > > [9.034310] BUG: KASAN: null-ptr-deref

Re: [LKP] [mm, oom] c1e4c54f9c: BUG:KASAN:null-ptr-deref_in_d

2018-07-30 Thread Michal Hocko
On Mon 30-07-18 19:05:50, David Rientjes wrote: > On Mon, 30 Jul 2018, Michal Hocko wrote: > > > On Mon 30-07-18 17:03:20, kernel test robot wrote: > > [...] > > > [9.034310] BUG: KASAN: null-ptr-deref in dump_header+0x10c/0x448 > > > > Could you faddr2line on the offset please? > > > > It'

Re: [LKP] [mm, oom] c1e4c54f9c: BUG:KASAN:null-ptr-deref_in_d

2018-07-30 Thread David Rientjes
On Mon, 30 Jul 2018, Michal Hocko wrote: > On Mon 30-07-18 17:03:20, kernel test robot wrote: > [...] > > [9.034310] BUG: KASAN: null-ptr-deref in dump_header+0x10c/0x448 > > Could you faddr2line on the offset please? > It's possible that p is NULL when calling dump_header(). In this case

Re: [LKP] [mm, oom] c1e4c54f9c: BUG:KASAN:null-ptr-deref_in_d

2018-07-30 Thread Rong Chen
On 07/30/2018 05:56 PM, Michal Hocko wrote: On Mon 30-07-18 17:03:20, kernel test robot wrote: [...] [9.034310] BUG: KASAN: null-ptr-deref in dump_header+0x10c/0x448 Could you faddr2line on the offset please? The result is: dump_header+0x10c/0x448: __read_once_size at include/linux/com

Re: [LKP] [mm, oom] c1e4c54f9c: BUG:KASAN:null-ptr-deref_in_d

2018-07-30 Thread Michal Hocko
On Mon 30-07-18 17:03:20, kernel test robot wrote: [...] > [9.034310] BUG: KASAN: null-ptr-deref in dump_header+0x10c/0x448 Could you faddr2line on the offset please? > [9.034310] Read of size 8 at addr 09b0 by task swapper/0/1 > [9.034310] > [9.034310] CPU: 0 PID: 1

[LKP] [mm, oom] c1e4c54f9c: BUG:KASAN:null-ptr-deref_in_d

2018-07-30 Thread kernel test robot
FYI, we noticed the following commit (built with gcc-5): commit: c1e4c54f9c750fc3ea4715f5363b92ea4d4efb29 ("mm, oom: reorganize the oom report in dump_header") https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master in testcase: boot on test machine: qemu-system-x86_64 -enable-k