Re: [Intel-gfx] [PATCH v2] drm/i915/gen9bc: Handle TGP PCH during suspend/resume

On Tue, Feb 16, 2021 at 09:36:01PM -0500, Lyude Paul wrote: > On Tue, 2021-02-16 at 20:08 +0200, Imre Deak wrote: > > Hi, > > > > thanks for respinning this patchset, some comments below. > > > > On Fri, Feb 12, 2021 at 01:50:53PM -0500, Lyude Paul wrote: > > > From: Tejas Upadhyay > > > > > >

Re: [Intel-gfx] [PATCH v2] drm/i915/gen9bc: Handle TGP PCH during suspend/resume

On Tue, 2021-02-16 at 21:36 -0500, Lyude Paul wrote: > On Tue, 2021-02-16 at 20:08 +0200, Imre Deak wrote: > > Hi, > > > > thanks for respinning this patchset, some comments below. > > > > On Fri, Feb 12, 2021 at 01:50:53PM -0500, Lyude Paul wrote: > > > From: Tejas Upadhyay > > > > > > For Leg

Re: [Intel-gfx] [PATCH v2] drm/i915/gen9bc: Handle TGP PCH during suspend/resume

On Tue, 2021-02-16 at 20:08 +0200, Imre Deak wrote: > Hi, > > thanks for respinning this patchset, some comments below. > > On Fri, Feb 12, 2021 at 01:50:53PM -0500, Lyude Paul wrote: > > From: Tejas Upadhyay > > > > For Legacy S3 suspend/resume GEN9 BC needs to enable and > > setup TGP PCH. >

Re: [Intel-gfx] [PATCH v2] drm/i915/gen9bc: Handle TGP PCH during suspend/resume

Hi, thanks for respinning this patchset, some comments below. On Fri, Feb 12, 2021 at 01:50:53PM -0500, Lyude Paul wrote: > From: Tejas Upadhyay > > For Legacy S3 suspend/resume GEN9 BC needs to enable and > setup TGP PCH. > > v2: > * Move Wa_14010685332 into it's own function - vsyrjala > * A