Re: [Hdaps-devel] [PATCH] hdaps - switch to using input-polldev

2007-07-09 Thread Shem Multinymous
On 7/9/07, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > Sounds good, then. It's a bit of a hack, but the benefits are well > worth it (if we can resolve the scheduling issue). You know, I slept on it and I think I want to move the polldev into opposite direction - to accomodte devices that need

Re: [Hdaps-devel] [PATCH] hdaps - switch to using input-polldev

2007-07-09 Thread Dmitry Torokhov
On Monday 09 July 2007 02:06, Shem Multinymous wrote: > > > > Have 2nd input device's ->open() method call input_open_device() for > > > > the first one. > > > > > > Won't that create an overhead by the redundant, unused notifications? > > > > They won't leave input core so nothing really noticeabl

Re: [Hdaps-devel] [PATCH] hdaps - switch to using input-polldev

2007-07-08 Thread Shem Multinymous
Hi, On 7/9/07, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: On Monday 09 July 2007 01:29, Shem Multinymous wrote: > > Every input event carries a timestamp so even if there are irregularities > > in taking the samples you should be able to account for it. > > The issue is how good are the input ev

Re: [Hdaps-devel] [PATCH] hdaps - switch to using input-polldev

2007-07-08 Thread Dmitry Torokhov
On Monday 09 July 2007 01:29, Shem Multinymous wrote: > On 7/9/07, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > > > > input-polldev uses a separate workqueue, not keventd, and so should not > > > > suffer from other workqueue users loading keventd. But if entire box > > > > is under stress then wor

Re: [Hdaps-devel] [PATCH] hdaps - switch to using input-polldev

2007-07-08 Thread Shem Multinymous
On 7/9/07, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > > input-polldev uses a separate workqueue, not keventd, and so should not > > suffer from other workqueue users loading keventd. But if entire box > > is under stress then workqueue vs timer context does not matter much - > > your daemon whi

Re: [Hdaps-devel] [PATCH] hdaps - switch to using input-polldev

2007-07-08 Thread Dmitry Torokhov
On Monday 09 July 2007 00:31, Shem Multinymous wrote: > Hi Dmitry, > > On 7/8/07, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > > > First, the hdaps driver regularly polls the embedded controller, which > > > in turns regularly polls the hardware. If the two polling rates differ > > > or fluctuate,

Re: [Hdaps-devel] [PATCH] hdaps - switch to using input-polldev

2007-07-08 Thread Shem Multinymous
Hi Dmitry, On 7/8/07, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > First, the hdaps driver regularly polls the embedded controller, which > in turns regularly polls the hardware. If the two polling rates differ > or fluctuate, we lose events. That was the case with the original driver as well b

Re: [Hdaps-devel] [PATCH] hdaps - switch to using input-polldev

2007-07-08 Thread Dmitry Torokhov
On Sunday 08 July 2007 21:00, Shem Multinymous wrote: > On 5/25/07, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > > HWMON: hdaps - convert to use input-polldev. > > > > Switch to using input-polldev skeleton instead of implementing > > polling loop by itself. This also fixes problem with trylock > >

Re: [Hdaps-devel] [PATCH] hdaps - switch to using input-polldev

2007-07-08 Thread Shem Multinymous
On 5/25/07, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: HWMON: hdaps - convert to use input-polldev. Switch to using input-polldev skeleton instead of implementing polling loop by itself. This also fixes problem with trylock on a mutex in atomic context. Signed-off-by: Dmitry Torokhov <[EMAIL PR