Re: [HP ProLiant WatchDog driver] hpwdt HP WatchDog Patch

2007-11-04 Thread Wim Van Sebroeck
Hi Thomas, I reviewed yor code and have ome remarks: * All watchdog device drivers should work with seconds. Your driver works with minutes. Please change to seconds. * The misc_register function (which opens your driver towards user-space) should be the last iregister-action you take into the pci

[HP ProLiant WatchDog driver] hpwdt HP WatchDog Patch

2007-10-24 Thread thomas . mingarelli
Hp is providing a Hardware WatchDog Timer driver that will only work with the specific HW Timer located in the HP ProLiant iLO 2 ASIC. The iLO 2 HW Timer will generate a Non-maskable Interrupt (NMI) 9 seconds before physically resetting the server, by removing power, so that the event can be logged

Re: [HP ProLiant WatchDog driver] hpwdt HP WatchDog Patch

2007-10-24 Thread Wim Van Sebroeck
Hi Thomas, > --- linux-2.6.23.1/drivers/char/watchdog/Makefile.orig2007-10-12 > 11:43:44.0 -0500 > +++ linux-2.6.23.1/drivers/char/watchdog/Makefile 2007-10-15 > 07:56:31.0 -0500 > @@ -118,3 +118,10 @@ > > # Architecture Independant > obj-$(CONFIG_SOFT_WATCHDOG) +

RE: [HP ProLiant WatchDog driver] hpwdt HP WatchDog Patch

2007-10-24 Thread Mingarelli, Thomas
: Mingarelli, Thomas Cc: linux-kernel@vger.kernel.org; Wim Van Sebroeck Subject: Re: [HP ProLiant WatchDog driver] hpwdt HP WatchDog Patch On Monday 22 October 2007 05:09:51 pm [EMAIL PROTECTED] wrote: > +config HP_WATCHDOG > +tristate "Hewlett-Packard watchdog" > +depends

RE: [HP ProLiant WatchDog driver] hpwdt HP WatchDog Patch

2007-10-23 Thread Mingarelli, Thomas
Van Sebroeck Subject: Re: [HP ProLiant WatchDog driver] hpwdt HP WatchDog Patch On Tue, Oct 23, 2007 at 02:31:15PM -0600, Bjorn Helgaas wrote: > The driver assumes only a single instance of the device. But PCI > being what it is, it's often possible to have multiple cards, so you &

Re: [HP ProLiant WatchDog driver] hpwdt HP WatchDog Patch

2007-10-23 Thread Christoph Hellwig
On Tue, Oct 23, 2007 at 02:31:15PM -0600, Bjorn Helgaas wrote: > The driver assumes only a single instance of the device. But PCI being > what it is, it's often possible to have multiple cards, so you might > want some protection in case you trip over more than one. Yes. And even with that prote

Re: [HP ProLiant WatchDog driver] hpwdt HP WatchDog Patch

2007-10-23 Thread Bjorn Helgaas
On Monday 22 October 2007 05:09:51 pm [EMAIL PROTECTED] wrote: > +config HP_WATCHDOG > +tristate "Hewlett-Packard watchdog" > +depends on WATCHDOG && X86 I wouldn't be surprised if this device someday turned up on non-x86 systems. I know there's some x86 firmware stuff in there th

[HP ProLiant WatchDog driver] hpwdt HP WatchDog Patch

2007-10-22 Thread thomas . mingarelli
Hp is providing a Hardware WatchDog Timer driver that will only work with the specific HW Timer located in the HP ProLiant iLO 2 ASIC. The iLO 2 HW Timer will generate a Non-maskable Interrupt (NMI) 9 seconds before physically resetting the server, by removing power, so that the event can be logged

Re: [HP ProLiant WatchDog driver] hpwdt HP WatchDog Patch

2007-10-22 Thread Andrew Morton
On Mon, 15 Oct 2007 14:05:50 -0400 (EDT) [EMAIL PROTECTED] wrote: > Hp is providing a Hardware WatchDog Timer driver that will only work with the > specific HW Timer located in the HP ProLiant iLO 2 ASIC. The iLO 2 HW Timer > will generate a Non-maskable Interrupt (NMI) 9 seconds before physically

RE: [HP ProLiant WatchDog driver] hpwdt HP WatchDog Patch

2007-10-15 Thread Mingarelli, Thomas
onday, October 15, 2007 1:16 PM To: Mingarelli, Thomas Cc: linux-kernel@vger.kernel.org; Mingarelli, Thomas Subject: Re: [HP ProLiant WatchDog driver] hpwdt HP WatchDog Patch On Mon, 15 Oct 2007 14:05:50 -0400 (EDT) [EMAIL PROTECTED] wrote: > Hp is providing a Hardware WatchDog Timer driver that w

Re: [HP ProLiant WatchDog driver] hpwdt HP WatchDog Patch

2007-10-15 Thread Andrey Panin
On 288, 10 15, 2007 at 02:05:50PM -0400, [EMAIL PROTECTED] wrote: > Hp is providing a Hardware WatchDog Timer driver that will only work with the > specific HW Timer located in the HP ProLiant iLO 2 ASIC. The iLO 2 HW Timer > will generate a Non-maskable Interrupt (NMI) 9 seconds before physically

Re: [HP ProLiant WatchDog driver] hpwdt HP WatchDog Patch

2007-10-15 Thread Arjan van de Ven
On Mon, 15 Oct 2007 14:05:50 -0400 (EDT) [EMAIL PROTECTED] wrote: > Hp is providing a Hardware WatchDog Timer driver that will only work > with the specific HW Timer located in the HP ProLiant iLO 2 ASIC. The > iLO 2 HW Timer will generate a Non-maskable Interrupt (NMI) 9 seconds > before physical

[HP ProLiant WatchDog driver] hpwdt HP WatchDog Patch

2007-10-15 Thread thomas . mingarelli
Hp is providing a Hardware WatchDog Timer driver that will only work with the specific HW Timer located in the HP ProLiant iLO 2 ASIC. The iLO 2 HW Timer will generate a Non-maskable Interrupt (NMI) 9 seconds before physically resetting the server, by removing power, so that the event can be logged