Re: [GIT PULL] x86/build change for v3.6

2012-07-29 Thread Sam Ravnborg
On Thu, Jul 26, 2012 at 08:55:06AM +0200, Ingo Molnar wrote: > > * Sam Ravnborg wrote: > > > > > > > No, the reason for the odd looking diff is that lots of lines in > > > arch/x86/Makefile have 8-space tabs for histerical reasons but > > > new code (such as this one) has proper tabs. > > >

Re: [GIT PULL] x86/build change for v3.6

2012-07-25 Thread Ingo Molnar
* Sam Ravnborg wrote: > > > > No, the reason for the odd looking diff is that lots of lines in > > arch/x86/Makefile have 8-space tabs for histerical reasons but > > new code (such as this one) has proper tabs. > > Use of tabs for indent in a Makefile is just asking for > trouble. Ok, I gu

Re: [GIT PULL] x86/build change for v3.6

2012-07-25 Thread H. Peter Anvin
On 07/25/2012 01:15 PM, Sam Ravnborg wrote: This is not as expected In this silly example it is maybe obvious but I have lost hours tracking down bugs due to this. You add a new target and suddenly someting unrelated breaks. What happens is that make consider the assignment a command due to

Re: [GIT PULL] x86/build change for v3.6

2012-07-25 Thread Sam Ravnborg
> > No, the reason for the odd looking diff is that lots of lines in > arch/x86/Makefile have 8-space tabs for histerical reasons but > new code (such as this one) has proper tabs. Use of tabs for indent in a Makefile is just asking for trouble. Consider following simple Makefile: $ cat Makefi

Re: [GIT PULL] x86/build change for v3.6

2012-07-23 Thread Kirill A. Shutemov
On Sun, Jul 22, 2012 at 04:22:04PM +0200, Ingo Molnar wrote: > > * Kirill A. Shutemov wrote: > > > On Sun, Jul 22, 2012 at 03:44:51PM +0200, Ingo Molnar wrote: > > > Linus, > > > > > > Please pull the latest x86-build-for-linus git tree from: > > > > > >git://git.kernel.org/pub/scm/linux/k

Re: [GIT PULL] x86/build change for v3.6

2012-07-22 Thread Ingo Molnar
* Kirill A. Shutemov wrote: > On Sun, Jul 22, 2012 at 03:44:51PM +0200, Ingo Molnar wrote: > > Linus, > > > > Please pull the latest x86-build-for-linus git tree from: > > > >git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > > x86-build-for-linus > > > >HEAD: d9b0cde91c60da

Re: [GIT PULL] x86/build change for v3.6

2012-07-22 Thread Kirill A. Shutemov
On Sun, Jul 22, 2012 at 03:44:51PM +0200, Ingo Molnar wrote: > Linus, > > Please pull the latest x86-build-for-linus git tree from: > >git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > x86-build-for-linus > >HEAD: d9b0cde91c60da0ed5f92cdc3ac878142e6b5f27 x86-64, gcc: Use > -m

[GIT PULL] x86/build change for v3.6

2012-07-22 Thread Ingo Molnar
Linus, Please pull the latest x86-build-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-build-for-linus HEAD: d9b0cde91c60da0ed5f92cdc3ac878142e6b5f27 x86-64, gcc: Use -mpreferred-stack-boundary=3 if supported Thanks, Ingo ---