Re: [GIT PULL] SLAB changes for v3.10

2013-05-08 Thread Konrad Rzeszutek Wilk
On Wed, May 08, 2013 at 02:13:53PM -0400, Chris Mason wrote: > [ Sorry if I break the threading on this, I had to pull it off gmane ] > > On Tue, 7 May 2013, Tony Lindgren wrote: > > OK got it narrowed down to CONFIG_DEBUG_SPINLOCK=y causing the problem > > with commit 8a965b3b. Ain't nothing like

Re: [GIT PULL] SLAB changes for v3.10

2013-05-08 Thread Tony Lindgren
* Christoph Lameter [130508 12:06]: > On Wed, 8 May 2013, Chris Mason wrote: > > > > You correctly moved the checks out of the if (!kmalloc_cacheS()) > > > condition so that the caches are created properly. > > > > But if the ordering is required at all, why is it ok to create cache 2 > > after c

Re: [GIT PULL] SLAB changes for v3.10

2013-05-08 Thread Tony Lindgren
* Christoph Lameter [130508 11:31]: > On Wed, 8 May 2013, Chris Mason wrote: > > > This patch fixes things for me, but to maintain the rules from > > Christoph's patch, kmalloc_caches[2] should have been created whenever > > kmalloc_caches[7] was done. > > Not necessary. The early slab bootstra

Re: [GIT PULL] SLAB changes for v3.10

2013-05-08 Thread Christoph Lameter
On Wed, 8 May 2013, Chris Mason wrote: > > You correctly moved the checks out of the if (!kmalloc_cacheS()) > > condition so that the caches are created properly. > > But if the ordering is required at all, why is it ok to create cache 2 > after cache 6 instead of after cache 7? The power of two

Re: [GIT PULL] SLAB changes for v3.10

2013-05-08 Thread Chris Mason
Quoting Christoph Lameter (2013-05-08 14:25:49) > On Wed, 8 May 2013, Chris Mason wrote: > > > This patch fixes things for me, but to maintain the rules from > > Christoph's patch, kmalloc_caches[2] should have been created whenever > > kmalloc_caches[7] was done. > > Not necessary. The early sl

Re: [GIT PULL] SLAB changes for v3.10

2013-05-08 Thread Christoph Lameter
On Wed, 8 May 2013, Chris Mason wrote: > This patch fixes things for me, but to maintain the rules from > Christoph's patch, kmalloc_caches[2] should have been created whenever > kmalloc_caches[7] was done. Not necessary. The early slab bootstrap must create some slab caches of specific sizes, i

Re: [GIT PULL] SLAB changes for v3.10

2013-05-08 Thread Christoph Lameter
> The 1.4.0 verion in ubuntu 13.04 s not good enough? qemu 1.4.0 reproduces the bug here on arm. And Chris Mason;s patch fixes it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.k

Re: [GIT PULL] SLAB changes for v3.10

2013-05-08 Thread Chris Mason
[ Sorry if I break the threading on this, I had to pull it off gmane ] On Tue, 7 May 2013, Tony Lindgren wrote: > OK got it narrowed down to CONFIG_DEBUG_SPINLOCK=y causing the problem > with commit 8a965b3b. Ain't nothing like bisecting and booting and then > diffing .config files on top of that.

Re: [GIT PULL] SLAB changes for v3.10

2013-05-08 Thread Tony Lindgren
* Christoph Lameter [130508 07:01]: > On Tue, 7 May 2013, Tony Lindgren wrote: > > > OK got it narrowed down to CONFIG_DEBUG_SPINLOCK=y causing the problem > > with commit 8a965b3b. Ain't nothing like bisecting and booting and then > > diffing .config files on top of that. > > > > > Without rever

Re: [GIT PULL] SLAB changes for v3.10

2013-05-08 Thread Christoph Lameter
On Tue, 7 May 2013, Tony Lindgren wrote: > OK got it narrowed down to CONFIG_DEBUG_SPINLOCK=y causing the problem > with commit 8a965b3b. Ain't nothing like bisecting and booting and then > diffing .config files on top of that. > > > Without reverting 8a965b3b I'm getting: The patch (commit 8a965

Re: [GIT PULL] SLAB changes for v3.10

2013-05-08 Thread Glauber Costa
On 05/08/2013 04:26 PM, Pekka Enberg wrote: > On Wed, May 8, 2013 at 2:58 PM, Glauber Costa wrote: >> My first guess is that it hit a NULL cache. Being a NULL pointer >> dereference, the thing among all that has the biggest chances of being >> NULL and accessed unconditionally is the cache pointer

Re: [GIT PULL] SLAB changes for v3.10

2013-05-08 Thread Pekka Enberg
On Wed, May 8, 2013 at 2:58 PM, Glauber Costa wrote: > My first guess is that it hit a NULL cache. Being a NULL pointer > dereference, the thing among all that has the biggest chances of being > NULL and accessed unconditionally is the cache pointer itself. > > Due to the size being too big. But i

Re: [GIT PULL] SLAB changes for v3.10

2013-05-08 Thread Glauber Costa
On 05/08/2013 10:20 AM, Pekka Enberg wrote: >> > Hmm it's actually CONFIG_PROVE_LOCKING=y that causes the problem, >> > not CONFIG_DEBUG_SPINLOCK=y. CONFIG_DEBUG_SPINLOCK=y was just selected >> > by CONFIG_PROVE_LOCKING=y in my non-booting .config. I can now fix my >> > non-booting .config by remov

Re: [GIT PULL] SLAB changes for v3.10

2013-05-07 Thread Pekka Enberg
Hi Tony, On Wed, May 8, 2013 at 8:16 AM, Tony Lindgren wrote: > * Tony Lindgren [130507 21:30]: >> * Tony Lindgren [130507 17:35]: >> > * Pekka Enberg [130506 23:42]: >> > > Hi Linus, >> > > >> > > Please pull the latest SLAB tree from: >> > > >> > > git://git.kernel.org/pub/scm/linux/kernel

Re: [GIT PULL] SLAB changes for v3.10

2013-05-07 Thread Tony Lindgren
* Tony Lindgren [130507 21:30]: > * Tony Lindgren [130507 17:35]: > > * Pekka Enberg [130506 23:42]: > > > Hi Linus, > > > > > > Please pull the latest SLAB tree from: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/penberg/linux.git > > > slab/for-linus > > ... > > > > > m

Re: [GIT PULL] SLAB changes for v3.10

2013-05-07 Thread Tony Lindgren
* Tony Lindgren [130507 17:35]: > * Pekka Enberg [130506 23:42]: > > Hi Linus, > > > > Please pull the latest SLAB tree from: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/penberg/linux.git > > slab/for-linus > ... > > > mm, slab_common: Fix bootstrap creation of kmalloc cache

Re: [GIT PULL] SLAB changes for v3.10

2013-05-07 Thread Tony Lindgren
* Pekka Enberg [130506 23:42]: > Hi Linus, > > Please pull the latest SLAB tree from: > > git://git.kernel.org/pub/scm/linux/kernel/git/penberg/linux.git > slab/for-linus ... > mm, slab_common: Fix bootstrap creation of kmalloc caches This one seems to cause a regression for me on at

[GIT PULL] SLAB changes for v3.10

2013-05-06 Thread Pekka Enberg
Hi Linus, Please pull the latest SLAB tree from: git://git.kernel.org/pub/scm/linux/kernel/git/penberg/linux.git slab/for-linus Bulk of the changes are more slab unification from Christoph. There's also few fixes from Aaron, Glauber, and Joonsoo thrown into the mix. Pe