Re: [GIT PULL] PCI fixes for v4.10

2017-05-06 Thread Lukas Wunner
Hi Ashok, On Wed, May 03, 2017 at 11:04:28AM -0700, Raj, Ashok wrote: > attached is recent set of experiments with your patch series applied > on 4.11 kernel. > > Right after a reboot, poweroff causes an NMI. You can see the message on > 1.dmesg. 1.lspci is after reboot, and 2.lspci is after a p

Re: [GIT PULL] PCI fixes for v4.10

2017-05-03 Thread Raj, Ashok
Hi Lukas attached is recent set of experiments with your patch series applied on 4.11 kernel. Right after a reboot, poweroff causes an NMI. You can see the message on 1.dmesg. 1.lspci is after reboot, and 2.lspci is after a poweroff/poweron sequence. You can see there are other differences, lik

Re: [GIT PULL] PCI fixes for v4.10

2017-05-02 Thread Bjorn Helgaas
On Tue, May 02, 2017 at 12:49:29PM +0200, Lukas Wunner wrote: > On Mon, May 01, 2017 at 10:41:20PM -0400, Sinan Kaya wrote: > > On 5/1/2017 9:54 PM, Lukas Wunner wrote: > > > (b) ASPM L1 enabled on boot, but disabled after powering off and back on > > > => I believe Sinan is working on this (+c

Re: [GIT PULL] PCI fixes for v4.10

2017-05-02 Thread Sinan Kaya
On 5/2/2017 6:49 AM, Lukas Wunner wrote: > On Mon, May 01, 2017 at 10:41:20PM -0400, Sinan Kaya wrote: >> On 5/1/2017 9:54 PM, Lukas Wunner wrote: >>> (b) ASPM L1 enabled on boot, but disabled after powering off and back on >>> => I believe Sinan is working on this (+cc). >> >> The decision was

Re: [GIT PULL] PCI fixes for v4.10

2017-05-02 Thread Lukas Wunner
On Mon, May 01, 2017 at 10:41:20PM -0400, Sinan Kaya wrote: > On 5/1/2017 9:54 PM, Lukas Wunner wrote: > > (b) ASPM L1 enabled on boot, but disabled after powering off and back on > > => I believe Sinan is working on this (+cc). > > The decision was made not to touch ASPM registers following h

Re: [GIT PULL] PCI fixes for v4.10

2017-05-01 Thread Sinan Kaya
On 5/1/2017 9:54 PM, Lukas Wunner wrote: > (b) ASPM L1 enabled on boot, but disabled after powering off and back on > => I believe Sinan is working on this (+cc). The decision was made not to touch ASPM registers following hotplug insertion unless pcie_aspm.policy=powersave is specified. The

Re: [GIT PULL] PCI fixes for v4.10

2017-05-01 Thread Lukas Wunner
Hi Ashok, sorry for the delay, I was swamped with work in the first quarter and am in the process of slowly going through my backlog... On Thu, Feb 09, 2017 at 10:46:13AM -0800, Raj, Ashok wrote: > I did a lspci and captured after a fresh reboot on the slot before > attempting a power off via s

[GIT PULL] PCI fixes for v4.10

2017-02-16 Thread Bjorn Helgaas
PCI fix: - add back pcie_pme_remove() so we free the IRQ when removing PCIe port devices; previously the leaked IRQ caused an MSI BUG_ON. The following changes since commit d98e0929071e7ef63d35c1838b0ad0805ae366dd: Revert "PCI: pciehp: Add runtime PM support for PCIe hotplug ports" (20

Re: [GIT PULL] PCI fixes for v4.10

2017-02-13 Thread Rafael J. Wysocki
On Sunday, February 12, 2017 08:05:02 PM Lukas Wunner wrote: > On Fri, Feb 10, 2017 at 06:39:16PM -0800, Yinghai Lu wrote: > > On Thu, Feb 9, 2017 at 12:11 PM, Bjorn Helgaas wrote: > > > On Thu, Feb 09, 2017 at 09:09:50AM -0600, Bjorn Helgaas wrote: > > > > On Thu, Feb 09, 2017 at 05:06:48AM +0100

Re: [GIT PULL] PCI fixes for v4.10

2017-02-12 Thread Lukas Wunner
On Fri, Feb 10, 2017 at 06:39:16PM -0800, Yinghai Lu wrote: > On Thu, Feb 9, 2017 at 12:11 PM, Bjorn Helgaas wrote: > > On Thu, Feb 09, 2017 at 09:09:50AM -0600, Bjorn Helgaas wrote: > > > On Thu, Feb 09, 2017 at 05:06:48AM +0100, Lukas Wunner wrote: > > > > https://patchwork.kernel.org/patch/9557

Re: [GIT PULL] PCI fixes for v4.10

2017-02-10 Thread Yinghai Lu
On Fri, Feb 10, 2017 at 6:39 PM, Yinghai Lu wrote: > Ashok, > > Can ask your QA guys check only attached patch and commit 68db9bc ? more clean patches: split that into two small patches. Thanks Yinghai From 68db9bc814362e7f24371c27d12a4f34477d9356 Mon Sep 17 00:00:00 2001 From: Lukas Wunner Da

Re: [GIT PULL] PCI fixes for v4.10

2017-02-10 Thread Yinghai Lu
On Thu, Feb 9, 2017 at 12:11 PM, Bjorn Helgaas wrote: > On Thu, Feb 09, 2017 at 09:09:50AM -0600, Bjorn Helgaas wrote: >> [+cc Ashok, Keith] >> >> On Thu, Feb 09, 2017 at 05:06:48AM +0100, Lukas Wunner wrote: >> > On Wed, Feb 08, 2017 at 01:22:56PM -0600, Bjorn Helgaas wrote: >> > > Bjorn Helgaas

Re: [GIT PULL] PCI fixes for v4.10

2017-02-10 Thread Rafael J. Wysocki
On Thursday, February 09, 2017 02:11:54 PM Bjorn Helgaas wrote: > On Thu, Feb 09, 2017 at 09:09:50AM -0600, Bjorn Helgaas wrote: > > [+cc Ashok, Keith] > > > > On Thu, Feb 09, 2017 at 05:06:48AM +0100, Lukas Wunner wrote: > > > On Wed, Feb 08, 2017 at 01:22:56PM -0600, Bjorn Helgaas wrote: > > > >

Re: [GIT PULL] PCI fixes for v4.10

2017-02-09 Thread Bjorn Helgaas
On Thu, Feb 09, 2017 at 09:09:50AM -0600, Bjorn Helgaas wrote: > [+cc Ashok, Keith] > > On Thu, Feb 09, 2017 at 05:06:48AM +0100, Lukas Wunner wrote: > > On Wed, Feb 08, 2017 at 01:22:56PM -0600, Bjorn Helgaas wrote: > > > Bjorn Helgaas (1): > > > Revert "PCI: pciehp: Add runtime PM support

Re: [GIT PULL] PCI fixes for v4.10

2017-02-09 Thread Raj, Ashok
Hi Bjorn/Lucas I did a lspci and captured after a fresh reboot on the slot before attempting a power off via sysfs. lspci-at-poweron - values after a cold reset poweron. lspci-aft-poweroff - values after a echo 0 > power lspci-aft-poweron - values after a echo 1 > power i would expect most or a

Re: [GIT PULL] PCI fixes for v4.10

2017-02-09 Thread Raj, Ashok
Thanks Bjorn, With the fixes below, managed add remove via sysfs seems to work on my SKX system. I'm not familiar with runtime PM aspects, just started looking into it after this one. There seems some interactions with ASPM and how we handle devices that support ARI for e.g. For hotplug, we h

Re: [GIT PULL] PCI fixes for v4.10

2017-02-09 Thread Bjorn Helgaas
[+cc Ashok, Keith] On Thu, Feb 09, 2017 at 05:06:48AM +0100, Lukas Wunner wrote: > On Wed, Feb 08, 2017 at 01:22:56PM -0600, Bjorn Helgaas wrote: > > Bjorn Helgaas (1): > > Revert "PCI: pciehp: Add runtime PM support for PCIe hotplug ports" > > What's the rationale for reverting this? > >

Re: [GIT PULL] PCI fixes for v4.10

2017-02-08 Thread Lukas Wunner
On Wed, Feb 08, 2017 at 01:22:56PM -0600, Bjorn Helgaas wrote: > Bjorn Helgaas (1): > Revert "PCI: pciehp: Add runtime PM support for PCIe hotplug ports" What's the rationale for reverting this? You've received patches to fix the issue on both affected machines, so a revert seems unnecessar

[GIT PULL] PCI fixes for v4.10

2017-02-08 Thread Bjorn Helgaas
[+cc, sorry for the duplicate] PCI fixes: - check MSI affinity vs. number of vectors to avoid memory corruption - drop runtime power management for PCIe hotplug ports for now to avoid regressing hotplug via sysfs The following changes since commit 030305d69fc6963c16003f50d7e8d74b02d0a14

Re: [GIT PULL] PCI fixes for v4.10

2017-02-02 Thread Bjorn Helgaas
On Thu, Feb 02, 2017 at 08:30:24AM -0800, Christoph Hellwig wrote: > On Thu, Feb 02, 2017 at 10:18:12AM -0600, Bjorn Helgaas wrote: > > PCI fixes: > > > > - configure ASPM on the link from a PCI-to-PCIe bridge (avoids a NULL > > pointer dereference on topologies including these bridges) > >

Re: [GIT PULL] PCI fixes for v4.10

2017-02-02 Thread Christoph Hellwig
On Thu, Feb 02, 2017 at 10:18:12AM -0600, Bjorn Helgaas wrote: > PCI fixes: > > - configure ASPM on the link from a PCI-to-PCIe bridge (avoids a NULL > pointer dereference on topologies including these bridges) Any reason you didn't include the affinity use outside the allocate range fix se

[GIT PULL] PCI fixes for v4.10

2017-02-02 Thread Bjorn Helgaas
PCI fixes: - configure ASPM on the link from a PCI-to-PCIe bridge (avoids a NULL pointer dereference on topologies including these bridges) The following changes since commit 4d191b1b63c209e37bf27938ef365244d3c41084: PCI/MSI: pci-xgene-msi: Fix CPU hotplug registration handling (2017-01-

[GIT PULL] PCI fixes for v4.10

2017-01-19 Thread Bjorn Helgaas
PCI fixes: - recognize that a PCI-to-PCIe bridge originates a PCIe hierarchy, so we enumerate that hierarchy correctly - X-Gene: fix a change merged for v4.10 that broke MSI - Keystone: avoid reading undefined registers, which can cause asynchronous external aborts - Supermicro