Re: [GIT PULL] Modules updates for v5.12

2021-02-25 Thread Masahiro Yamada
On Fri, Feb 26, 2021 at 1:19 AM Rasmus Villemoes wrote: > > On 25/02/2021 16.49, Masahiro Yamada wrote: > > On Thu, Feb 25, 2021 at 4:36 AM Rasmus Villemoes > > wrote: > >> > >> On 24/02/2021 15.40, Masahiro Yamada wrote: > > > > > > Good insight. > > Actually, I came up with the same idea last n

Re: [GIT PULL] Modules updates for v5.12

2021-02-25 Thread Rasmus Villemoes
On 25/02/2021 16.49, Masahiro Yamada wrote: > On Thu, Feb 25, 2021 at 4:36 AM Rasmus Villemoes > wrote: >> >> On 24/02/2021 15.40, Masahiro Yamada wrote: > > > Good insight. > Actually, I came up with the same idea last night, and had started > the implementation background. > I needed sleep bef

Re: [GIT PULL] Modules updates for v5.12

2021-02-25 Thread Masahiro Yamada
On Fri, Feb 26, 2021 at 12:49 AM Masahiro Yamada wrote: > > On Thu, Feb 25, 2021 at 4:36 AM Rasmus Villemoes > wrote: > > > > On 24/02/2021 15.40, Masahiro Yamada wrote: > > > On Wed, Feb 24, 2021 at 5:33 PM Jessica Yu wrote: > > >> > > >> +++ Linus Torvalds [23/02/21 12:03 -0800]: > > >>> On Tu

Re: [GIT PULL] Modules updates for v5.12

2021-02-25 Thread Masahiro Yamada
On Thu, Feb 25, 2021 at 4:36 AM Rasmus Villemoes wrote: > > On 24/02/2021 15.40, Masahiro Yamada wrote: > > On Wed, Feb 24, 2021 at 5:33 PM Jessica Yu wrote: > >> > >> +++ Linus Torvalds [23/02/21 12:03 -0800]: > >>> On Tue, Feb 23, 2021 at 12:01 PM Christoph Hellwig wrote: > > Does yo

Re: [GIT PULL] Modules updates for v5.12

2021-02-24 Thread Rasmus Villemoes
On 24/02/2021 15.40, Masahiro Yamada wrote: > On Wed, Feb 24, 2021 at 5:33 PM Jessica Yu wrote: >> >> +++ Linus Torvalds [23/02/21 12:03 -0800]: >>> On Tue, Feb 23, 2021 at 12:01 PM Christoph Hellwig wrote: Does your build now enable TRIM_UNUSED_KSYMS but previously didn't by chanc

Re: [GIT PULL] Modules updates for v5.12

2021-02-24 Thread Linus Torvalds
On Wed, Feb 24, 2021 at 6:47 AM Masahiro Yamada wrote: > > I prefer a one-liner, 'depends on !COMPILE_TEST'. > !COMPILE_TEST is not super elegant, but > it is used in several spaces. Yeah, I'll do that. I'll also make it an EXPERT-only question, which is what we tend to do for a lot of special "

Re: [GIT PULL] Modules updates for v5.12

2021-02-24 Thread Masahiro Yamada
On Wed, Feb 24, 2021 at 11:46 PM Masahiro Yamada wrote: > > On Wed, Feb 24, 2021 at 11:13 PM Jessica Yu wrote: > > > > +++ Christoph Hellwig [24/02/21 08:52 +0100]: > > >On Tue, Feb 23, 2021 at 12:07:39PM -0800, Linus Torvalds wrote: > > >> On Tue, Feb 23, 2021 at 12:03 PM Linus Torvalds > > >>

Re: [GIT PULL] Modules updates for v5.12

2021-02-24 Thread Masahiro Yamada
On Wed, Feb 24, 2021 at 11:13 PM Jessica Yu wrote: > > +++ Christoph Hellwig [24/02/21 08:52 +0100]: > >On Tue, Feb 23, 2021 at 12:07:39PM -0800, Linus Torvalds wrote: > >> On Tue, Feb 23, 2021 at 12:03 PM Linus Torvalds > >> wrote: > >> > > >> > This is unacceptably slow. If that symbol trimming

Re: [GIT PULL] Modules updates for v5.12

2021-02-24 Thread Masahiro Yamada
On Wed, Feb 24, 2021 at 5:33 PM Jessica Yu wrote: > > +++ Linus Torvalds [23/02/21 12:03 -0800]: > >On Tue, Feb 23, 2021 at 12:01 PM Christoph Hellwig wrote: > >> > >> Does your build now enable TRIM_UNUSED_KSYMS but previously didn't by > >> chance? > > > >Crossed emails. > > > >This is plain "m

Re: [GIT PULL] Modules updates for v5.12

2021-02-24 Thread Jessica Yu
+++ Christoph Hellwig [24/02/21 08:52 +0100]: On Tue, Feb 23, 2021 at 12:07:39PM -0800, Linus Torvalds wrote: On Tue, Feb 23, 2021 at 12:03 PM Linus Torvalds wrote: > > This is unacceptably slow. If that symbol trimming takes 30% of the > whole kernel build time, it needs to be fixed or removed

Re: [GIT PULL] Modules updates for v5.12

2021-02-24 Thread Jessica Yu
+++ Linus Torvalds [23/02/21 12:03 -0800]: On Tue, Feb 23, 2021 at 12:01 PM Christoph Hellwig wrote: Does your build now enable TRIM_UNUSED_KSYMS but previously didn't by chance? Crossed emails. This is plain "make allmodconfig", so yes, now it will enable TRIM_UNUSED_KSYMS. This is unacce

Re: [GIT PULL] Modules updates for v5.12

2021-02-23 Thread Christoph Hellwig
On Tue, Feb 23, 2021 at 12:07:39PM -0800, Linus Torvalds wrote: > On Tue, Feb 23, 2021 at 12:03 PM Linus Torvalds > wrote: > > > > This is unacceptably slow. If that symbol trimming takes 30% of the > > whole kernel build time, it needs to be fixed or removed. > > I think I'm going to mark TRIM_U

Re: [GIT PULL] Modules updates for v5.12

2021-02-23 Thread pr-tracker-bot
The pull request you sent on Tue, 23 Feb 2021 16:42:36 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/jeyu/linux.git > tags/modules-for-v5.12 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/21a6ab2131ab0644eeef70507e20273338bf065c Thank you! -- Deet-doot-dot

Re: [GIT PULL] Modules updates for v5.12

2021-02-23 Thread Linus Torvalds
On Tue, Feb 23, 2021 at 12:03 PM Linus Torvalds wrote: > > This is unacceptably slow. If that symbol trimming takes 30% of the > whole kernel build time, it needs to be fixed or removed. I think I'm going to mark TRIM_UNUSED_KSYMS as "depends on BROKEN". There's no way I can accept that horrible

Re: [GIT PULL] Modules updates for v5.12

2021-02-23 Thread Linus Torvalds
On Tue, Feb 23, 2021 at 12:01 PM Christoph Hellwig wrote: > > Does your build now enable TRIM_UNUSED_KSYMS but previously didn't by > chance? Crossed emails. This is plain "make allmodconfig", so yes, now it will enable TRIM_UNUSED_KSYMS. This is unacceptably slow. If that symbol trimming takes

Re: [GIT PULL] Modules updates for v5.12

2021-02-23 Thread Linus Torvalds
On Tue, Feb 23, 2021 at 11:55 AM Linus Torvalds wrote: > > I don't see quite what is wrong, but bisection is clear, and points > the finger at > > 367948220fce "module: remove EXPORT_UNUSED_SYMBOL*" > > which looks entirely trivial, but clearly isn't. > > It's repeatable. That commit slows dow

Re: [GIT PULL] Modules updates for v5.12

2021-02-23 Thread Christoph Hellwig
On Tue, Feb 23, 2021 at 11:55:50AM -0800, Linus Torvalds wrote: > On Tue, Feb 23, 2021 at 10:42 AM Linus Torvalds > wrote: > > > > I think there is something horribly wrong in my tree, and my build > > process is now about 30% slower. It went from 5+ minutes to 8+ > > minutes. The main suspect wou

Re: [GIT PULL] Modules updates for v5.12

2021-02-23 Thread Linus Torvalds
On Tue, Feb 23, 2021 at 10:42 AM Linus Torvalds wrote: > > I think there is something horribly wrong in my tree, and my build > process is now about 30% slower. It went from 5+ minutes to 8+ > minutes. The main suspect would be some lack of parallelism. I don't see quite what is wrong, but bisect

Re: [GIT PULL] Modules updates for v5.12

2021-02-23 Thread Linus Torvalds
On Tue, Feb 23, 2021 at 10:26 AM Linus Torvalds wrote: > > On Tue, Feb 23, 2021 at 7:42 AM Jessica Yu wrote: > > > > Please pull below to receive modules updates for the v5.12 merge window. > > Pulled. Actually, I take that back. I think there is something horribly wrong in my tree, and my buil

Re: [GIT PULL] Modules updates for v5.12

2021-02-23 Thread Linus Torvalds
On Tue, Feb 23, 2021 at 7:42 AM Jessica Yu wrote: > > Please pull below to receive modules updates for the v5.12 merge window. "struct symsearch is only used inside of module.h, so move the definition out of module.h" Whaa? The first module.h should be module.c. Oh well. Pulled.

[GIT PULL] Modules updates for v5.12

2021-02-23 Thread Jessica Yu
Hi Linus, Please pull below to receive modules updates for the v5.12 merge window. A summary can be found in the signed tag. Thank you, Jessica --- The following changes since commit 19c329f6808995b142b3966301f217c831e7cf31: Linux 5.11-rc4 (2021-01-17 16:37:05 -0800) are available in the G