Re: [GIT] Digital signature library bugfix

2012-09-14 Thread Kasatkin, Dmitry
On Thu, Sep 13, 2012 at 7:53 AM, James Morris wrote: > On Thu, 13 Sep 2012, Linus Torvalds wrote: > >> On Wed, Sep 12, 2012 at 6:22 PM, Kasatkin, Dmitry >> wrote: >> > >> > But I will re-send updated patch in a moment. >> >> Ok, I took that updated patch instead of the pull request, since I >> li

Re: [GIT] Digital signature library bugfix

2012-09-12 Thread James Morris
On Thu, 13 Sep 2012, Linus Torvalds wrote: > On Wed, Sep 12, 2012 at 6:22 PM, Kasatkin, Dmitry > wrote: > > > > But I will re-send updated patch in a moment. > > Ok, I took that updated patch instead of the pull request, since I > liked that much more, and hadn't actually pushed out the pull yet

Re: [GIT] Digital signature library bugfix

2012-09-12 Thread Linus Torvalds
On Wed, Sep 12, 2012 at 6:22 PM, Kasatkin, Dmitry wrote: > > But I will re-send updated patch in a moment. Ok, I took that updated patch instead of the pull request, since I liked that much more, and hadn't actually pushed out the pull yet. Linus -- To unsubscribe from this list: send

Re: [GIT] Digital signature library bugfix

2012-09-12 Thread Kasatkin, Dmitry
On Wed, Sep 12, 2012 at 8:38 AM, Linus Torvalds wrote: > On Wed, Sep 12, 2012 at 11:34 AM, James Morris wrote: >> >> - if (!err && len == hlen) >> - err = memcmp(out2, h, hlen); >> + if (err || len != hlen) { >> + err = -EINVAL; >> + goto err;

Re: [GIT] Digital signature library bugfix

2012-09-11 Thread Linus Torvalds
On Wed, Sep 12, 2012 at 11:34 AM, James Morris wrote: > > - if (!err && len == hlen) > - err = memcmp(out2, h, hlen); > + if (err || len != hlen) { > + err = -EINVAL; > + goto err; > + } > + > + err = memcmp(out2, h, hlen); > > err

[GIT] Digital signature library bugfix

2012-09-11 Thread James Morris
Please apply for v3.6. The following changes since commit 0bd1189e239c76eb3a50e458548fbe7e4a5dfff1: Linus Torvalds (1): Merge branch 'for-3.6-fixes' of git://git.kernel.org/.../tj/wq are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-s