Re: [EXTERNAL][PATCH 1/5] PCI: Convert pci_resource_to_user to a weak function

Hi Paul, On 29.07.2019 01:49, Paul Burton wrote: Hi Denis, This is wrong - using __weak on the declaration in a header will cause the weak attribute to be applied to all implementations too (presuming the C files containing the implementations include the header). You then get whichever impleen

Re: [EXTERNAL][PATCH 1/5] PCI: Convert pci_resource_to_user to a weak function

On Sun, 2019-07-28 at 22:49 +, Paul Burton wrote: > Hi Denis, > > On Sun, Jul 28, 2019 at 11:22:09PM +0300, Denis Efremov wrote: > > diff --git a/include/linux/pci.h b/include/linux/pci.h > > index 9e700d9f9f28..1a19d0151b0a 100644 > > --- a/include/linux/pci.h > > +++ b/include/linux/pci.h >

Re: [EXTERNAL][PATCH 1/5] PCI: Convert pci_resource_to_user to a weak function

Hi Denis, On Sun, Jul 28, 2019 at 11:22:09PM +0300, Denis Efremov wrote: > diff --git a/include/linux/pci.h b/include/linux/pci.h > index 9e700d9f9f28..1a19d0151b0a 100644 > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -1870,25 +1870,13 @@ static inline const char *pci_name(const str