Re: [CHECKER] question about functions that can fail

2001-03-23 Thread Rusty Russell
In message <[EMAIL PROTECTED]> you write: >skb_queue_len : 56 : 2: skb_queue_len not being checked? Look at these two places: either your analysis has a bug, or there's some wierd code... skb_push and skb_pull return the new skb data region, but

Re: [CHECKER] question about functions that can fail

2001-03-19 Thread Andreas Dilger
Dawson writes: > right now we are trying to derive which functions can "reasonably" fail > by examining all call sites and recording the number of times functions > are checked vs not checked. First of all, thanks for this interesting work you are doing. Pre-emptive bug squashing is great. Prob

[CHECKER] question about functions that can fail

2001-03-19 Thread Dawson Engler
Hi All, right now we are trying to derive which functions can "reasonably" fail by examining all call sites and recording the number of times functions are checked vs not checked. Checking includes comparisions <, >, != 0 directly: /* these are all checked uses */ if(foo())