Re: [CFT][RFC] ext2_new_inode() fixes and cleanup

2000-12-01 Thread Alexander Viro
On Thu, 30 Nov 2000, Theodore Y. Ts'o wrote: > If you could send me the split up, I'd appreciate it, as it'll make it > easier to find any subtle bugs. I certainly like the general way you've > cleaned up the interfaces and factored out the code. See attachments. Order of patches is alphabeti

Re: [CFT][RFC] ext2_new_inode() fixes and cleanup

2000-12-01 Thread Alexander Viro
On Fri, 1 Dec 2000, Andreas Dilger wrote: > Alexander, Ted, > I was taking a hard look at the proposed changes. In load_inode_bitmap() > we shouldn't be cacheing the I/O error case (this was in the old code too). I know. I left it in place since I don't like the idea of putting many not-absol

Re: [CFT][RFC] ext2_new_inode() fixes and cleanup

2000-12-01 Thread Andreas Dilger
Alexander, Ted, I was taking a hard look at the proposed changes. In load_inode_bitmap() we shouldn't be cacheing the I/O error case (this was in the old code too). It means we don't have to check for NULL bh in the table cache each time through, and for (s_groups_count < MAX_GROUPS_LOADED) case

Re: [CFT][RFC] ext2_new_inode() fixes and cleanup

2000-11-30 Thread Theodore Y. Ts'o
Date: Thu, 30 Nov 2000 17:13:27 -0500 (EST) From: Alexander Viro <[EMAIL PROTECTED]> * search for appropriate cylinder group had been taken out of the ext2_new_inode() into helper functions - find_cg_dir(sb, parent_group) and find_cg_other(sb, parent_group). Bug caught by D

[CFT][RFC] ext2_new_inode() fixes and cleanup

2000-11-30 Thread Alexander Viro
* search for appropriate cylinder group had been taken out of the ext2_new_inode() into helper functions - find_cg_dir(sb, parent_group) and find_cg_other(sb, parent_group). Bug caught by Daniel (wrong bh being dirtied when we update the free inodes counter) - fixed. * ext2_new_ino