[PATCH] [Bugme-new] [Bug 8957] New: Exported functions and variables

2007-09-01 Thread Matti Linnanvuori
This is a kernel/module.c Linux 2.6.23-rc5 documentation patch that adds more explanation and corrects a spelling error. --- kernel/module.c 2007-09-01 14:15:06.131101500 +0300 +++ patched-kernel/module.c 2007-09-01 14:15:27.502780500 +0300 @@ -80,7 +80,8 @@ int unregister_module_notifier(stru

Re: [Bugme-new] [Bug 8957] New: Exported functions and variables

2007-08-31 Thread Satyam Sharma
On Fri, 31 Aug 2007, Matti Linnanvuori wrote: > > It seems to me that kernel/module.c allows the whole kernel to use > exported symbols during the execution of the init function if they are > weak: > /* Ok if weak. */ > if (ELF_ST_BIND(sym[i].st

Re: [Bugme-new] [Bug 8957] New: Exported functions and variables

2007-08-31 Thread Arjan van de Ven
On Fri, 31 Aug 2007 10:14:27 -0700 (PDT) Matti Linnanvuori <[EMAIL PROTECTED]> wrote: > It seems to me that kernel/module.c allows the whole kernel to use > exported symbols during the execution of the init function if they > are weak: /* Ok if weak. */ if (ELF_ST_BIND(sym[i].st_info) == > STB_WE

[Bugme-new] [Bug 8957] New: Exported functions and variables

2007-08-31 Thread Matti Linnanvuori
It seems to me that kernel/module.c allows the whole kernel to use exported symbols during the execution of the init function if they are weak: /* Ok if weak. */ if (ELF_ST_BIND(sym[i].st_info) == STB_WEAK) break;

Re: [Bugme-new] [Bug 8957] New: Exported functions and variables

2007-08-31 Thread Satyam Sharma
Hi Matti, On Thu, 30 Aug 2007, Matti Linnanvuori wrote: > > I thought I had seen that bug. Module init function execution does not > seem serialized enough, so the init function of one module seems to be > able to be called in parallel with several other modules in turn being > loaded, executing

Re: [Bugme-new] [Bug 8957] New: Exported functions and variables should not be reachable by the outside of the module until module_init finishes

2007-08-31 Thread Satyam Sharma
Hi Andrew, On Wed, 29 Aug 2007, Andrew Morton wrote: > On Wed, 29 Aug 2007 19:33:48 -0600 Robert Hancock <[EMAIL PROTECTED]> wrote: > > > Andrew Morton wrote: > > > On Wed, 29 Aug 2007 11:33:06 -0700 (PDT) [EMAIL PROTECTED] wrote: > > > > > >> http://bugzilla.kernel.org/show_bug.cgi?id=8957 >

[Bugme-new] [Bug 8957] New: Exported functions and variables

2007-08-30 Thread Matti Linnanvuori
I thought I had seen that bug. Module init function execution does not seem serialized enough, so the init function of one module seems to be able to be called in parallel with several other modules in turn being loaded, executing their init functions and even becoming live first class citizens.

Re: [Bugme-new] [Bug 8957] New: Exported functions and variables should not be reachable by the outside of the module until module_init finishes

2007-08-30 Thread Satyam Sharma
On Wed, 29 Aug 2007, Robert Hancock wrote: > Andrew Morton wrote: > > On Wed, 29 Aug 2007 11:33:06 -0700 (PDT) [EMAIL PROTECTED] > > wrote: > > > > > http://bugzilla.kernel.org/show_bug.cgi?id=8957 > > > > > >Summary: Exported functions and variables should not be > > > reachable >

Re: [Bugme-new] [Bug 8957] New: Exported functions and variables

2007-08-30 Thread Arjan van de Ven
On Thu, 30 Aug 2007 09:41:41 -0700 (PDT) Matti Linnanvuori <[EMAIL PROTECTED]> wrote: > I thought that the bug might happen when two kernel modules are being > loaded. If module A is loaded and its code includes references to > functions exported by module B, I thought module A could call those >

[Bugme-new] [Bug 8957] New: Exported functions and variables

2007-08-30 Thread Matti Linnanvuori
I thought that the bug might happen when two kernel modules are being loaded. If module A is loaded and its code includes references to functions exported by module B, I thought module A could call those functions before the module_init function of module B has finished. I was not thinking about

Re: [Bugme-new] [Bug 8957] New: Exported functions and variables should not be reachable by the outside of the module until module_init finishes

2007-08-29 Thread Andrew Morton
On Wed, 29 Aug 2007 19:33:48 -0600 Robert Hancock <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > On Wed, 29 Aug 2007 11:33:06 -0700 (PDT) [EMAIL PROTECTED] wrote: > > > >> http://bugzilla.kernel.org/show_bug.cgi?id=8957 > >> > >>Summary: Exported functions and variables should

Re: [Bugme-new] [Bug 8957] New: Exported functions and variables should not be reachable by the outside of the module until module_init finishes

2007-08-29 Thread Robert Hancock
Andrew Morton wrote: On Wed, 29 Aug 2007 11:33:06 -0700 (PDT) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=8957 Summary: Exported functions and variables should not be reachable by the outside of the module until module_init finishes

Re: [Bugme-new] [Bug 8957] New: Exported functions and variables should not be reachable by the outside of the module until module_init finishes

2007-08-29 Thread Andrew Morton
On Wed, 29 Aug 2007 11:33:06 -0700 (PDT) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=8957 > >Summary: Exported functions and variables should not be reachable > by the outside of the module until module_init finishes >Product: