Re: [BUG] raid5 crash with 2.4.0-test12 [Was: Linux-2.4.0-test12]

2000-12-13 Thread Neil Brown
On Tuesday December 12, [EMAIL PROTECTED] wrote: > > > On Wed, 13 Dec 2000, Neil Brown wrote: > > > > Yes... you are right. Alright, I can't escape it any other way so I > > guess I must admit that it is a raid5 bug. > > > > But how can raid5 be calling b_end_io on a buffer_head that was nev

Re: [BUG] raid5 crash with 2.4.0-test12 [Was: Linux-2.4.0-test12]

2000-12-13 Thread Jasper Spaans
On Tue, Dec 12, 2000 at 07:08:09PM -0800, Linus Torvalds wrote: > > The following patch disabled that code. > > If this fix makes the oops go away, then the proper fix for the problem is > not the #if 0, but do add something like Well, this fix did make the oops go away, but it also caused anot

Re: [BUG] raid5 crash with 2.4.0-test12 [Was: Linux-2.4.0-test12]

2000-12-12 Thread Linus Torvalds
On Wed, 13 Dec 2000, Neil Brown wrote: > > Yes... you are right. Alright, I can't escape it any other way so I > guess I must admit that it is a raid5 bug. > > But how can raid5 be calling b_end_io on a buffer_head that was never > passed to generic_make_request? > Answer, it snoops on the b

Re: [BUG] raid5 crash with 2.4.0-test12 [Was: Linux-2.4.0-test12]

2000-12-12 Thread Neil Brown
On Tuesday December 12, [EMAIL PROTECTED] wrote: > > > On Wed, 13 Dec 2000, Neil Brown wrote: > > > > Could you add this test to the top of md_make_request as well, because > > requests to raid5 don't go through generic_make_request. > > Sure they do. Everything that calls ll_rw_block() or subm

Re: [BUG] raid5 crash with 2.4.0-test12 [Was: Linux-2.4.0-test12]

2000-12-12 Thread Linus Torvalds
On Wed, 13 Dec 2000, Neil Brown wrote: > > Could you add this test to the top of md_make_request as well, because > requests to raid5 don't go through generic_make_request. Sure they do. Everything that calls ll_rw_block() or submit_bh() will go through generic_make_request. Neil, you're proba

Re: [BUG] raid5 crash with 2.4.0-test12 [Was: Linux-2.4.0-test12]

2000-12-12 Thread Neil Brown
On Tuesday December 12, [EMAIL PROTECTED] wrote: > On Tue, Dec 12, 2000 at 11:06:07AM -0800, Linus Torvalds wrote: > > > > To get better debug output, could you please do something for me? > > > > In fs/buffer.c, get rid of "end_buffer_io_bad" completely, and replace all > > users of it with NUL

Re: [BUG] raid5 crash with 2.4.0-test12 [Was: Linux-2.4.0-test12]

2000-12-12 Thread Jasper Spaans
On Tue, Dec 12, 2000 at 11:06:07AM -0800, Linus Torvalds wrote: > > Dec 12 14:04:50 spaans kernel: invalid operand: > > Dec 12 14:04:50 spaans kernel: CPU:1 > > Dec 12 14:04:50 spaans kernel: EIP:0010:[end_buffer_io_bad+85/92] > > > > Dec 12 14:04:50 spaans kernel: Call Trace: > >

Re: [BUG] raid5 crash with 2.4.0-test12 [Was: Linux-2.4.0-test12]

2000-12-12 Thread Jasper Spaans
On Wed, Dec 13, 2000 at 06:56:22AM +1100, Neil Brown wrote: > Guilt by association :-) > > What this bit of code (complete_stripe/raid5_end_buffer_io) is doing > is observing that it as completed some I/O request that was made of > the raid5 device and is calling the b_end_io on the buffer_head

Re: [BUG] raid5 crash with 2.4.0-test12 [Was: Linux-2.4.0-test12]

2000-12-12 Thread Neil Brown
On Tuesday December 12, [EMAIL PROTECTED] wrote: > > > On Tue, 12 Dec 2000, Jasper Spaans wrote: > > > On Mon, Dec 11, 2000 at 06:52:55PM -0800, Linus Torvalds wrote: > > > > > > Ok, there it is. Noticeable changes from pre8 are mainly (a) new tq list > > > compile fixes and (b) the NetApp sna

Re: [BUG] raid5 crash with 2.4.0-test12 [Was: Linux-2.4.0-test12]

2000-12-12 Thread Linus Torvalds
On Tue, 12 Dec 2000, Jasper Spaans wrote: > On Mon, Dec 11, 2000 at 06:52:55PM -0800, Linus Torvalds wrote: > > > > Ok, there it is. Noticeable changes from pre8 are mainly (a) new tq list > > compile fixes and (b) the NetApp snapshot thing. > > > - final: > > - Neil Brown: raid and md c

[BUG] raid5 crash with 2.4.0-test12 [Was: Linux-2.4.0-test12]

2000-12-12 Thread Jasper Spaans
On Mon, Dec 11, 2000 at 06:52:55PM -0800, Linus Torvalds wrote: > > Ok, there it is. Noticeable changes from pre8 are mainly (a) new tq list > compile fixes and (b) the NetApp snapshot thing. > - final: > - Neil Brown: raid and md cleanups Hmm, while doing some not-so-heavy things with a m