Re: [BUG] lib: zram lz4 compression/decompression still broken on big endian

2016-04-08 Thread Rui Salvaterra
2016-04-07 15:07 GMT+01:00 Sergey Senozhatsky : > On (04/07/16 13:33), Rui Salvaterra wrote: > [..] >> Hi again, Sergey > > Hello, > >> Thanks for the patch, I'll test it as soon as possible. I agree with >> your second option, usually one selects lz4 when (especially >> decompression) speed is par

Re: [BUG] lib: zram lz4 compression/decompression still broken on big endian

2016-04-07 Thread Sergey Senozhatsky
On (04/07/16 13:33), Rui Salvaterra wrote: [..] > Hi again, Sergey Hello, > Thanks for the patch, I'll test it as soon as possible. I agree with > your second option, usually one selects lz4 when (especially > decompression) speed is paramount, so it needs all the help it can > get. thanks! > S

Re: [BUG] lib: zram lz4 compression/decompression still broken on big endian

2016-04-07 Thread Rui Salvaterra
2016-04-06 14:09 GMT+01:00 Sergey Senozhatsky : > Cc Chanho Min, Kyungsik Lee > > > Hello, > > On (04/06/16 10:39), Rui Salvaterra wrote: >> > may we please ask you to test the patch first? quite possible there >> > is nothing to fix there; I've no access to mips h/w but the patch >> > seems correc

Re: [BUG] lib: zram lz4 compression/decompression still broken on big endian

2016-04-06 Thread Sergey Senozhatsky
Cc Chanho Min, Kyungsik Lee Hello, On (04/06/16 10:39), Rui Salvaterra wrote: > > may we please ask you to test the patch first? quite possible there > > is nothing to fix there; I've no access to mips h/w but the patch > > seems correct to me. > > > > LZ4_READ_LITTLEENDIAN_16 does get_unaligned

Re: [BUG] lib: zram lz4 compression/decompression still broken on big endian

2016-04-06 Thread Rui Salvaterra
2016-04-06 6:33 GMT+01:00 Sergey Senozhatsky : > On (04/05/16 17:02), Rui Salvaterra wrote: > [..] >> > For some reason it never got merged, sorry, I don't remember why. >> > >> > Have you tested this patch? If so, can you resend it with your >> > tested-by: line added to it? >> > >> > thanks, >>

Re: [BUG] lib: zram lz4 compression/decompression still broken on big endian

2016-04-05 Thread Sergey Senozhatsky
On (04/05/16 17:02), Rui Salvaterra wrote: [..] > > For some reason it never got merged, sorry, I don't remember why. > > > > Have you tested this patch? If so, can you resend it with your > > tested-by: line added to it? > > > > thanks, > > > > greg k-h > > Hi, Greg > > > No, I haven't tested

Re: [BUG] lib: zram lz4 compression/decompression still broken on big endian

2016-04-05 Thread Rui Salvaterra
2016-04-05 16:34 GMT+01:00 Greg KH : > On Tue, Apr 05, 2016 at 03:07:48PM +0100, Rui Salvaterra wrote: >> Hi, >> >> >> I apologise in advance if I've cc'ed too many/the wrong people/lists. >> >> Whenever I try to use zram with lz4, on my Power Mac G5 (tested with >> kernel 4.4.0-16-powerpc64-smp fr

Re: [BUG] lib: zram lz4 compression/decompression still broken on big endian

2016-04-05 Thread Greg KH
On Tue, Apr 05, 2016 at 03:07:48PM +0100, Rui Salvaterra wrote: > Hi, > > > I apologise in advance if I've cc'ed too many/the wrong people/lists. > > Whenever I try to use zram with lz4, on my Power Mac G5 (tested with > kernel 4.4.0-16-powerpc64-smp from Ubuntu 16.04 LTS), I get the > following

[BUG] lib: zram lz4 compression/decompression still broken on big endian

2016-04-05 Thread Rui Salvaterra
Hi, I apologise in advance if I've cc'ed too many/the wrong people/lists. Whenever I try to use zram with lz4, on my Power Mac G5 (tested with kernel 4.4.0-16-powerpc64-smp from Ubuntu 16.04 LTS), I get the following on my dmesg: [13150.675820] zram: Added device: zram0 [13150.704133] zram0: de