Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

2018-05-19 Thread Hans de Goede
Hi, On 18-05-18 15:15, Jarkko Nikula wrote: On 05/18/2018 10:48 AM, Hans de Goede wrote: Could it be the i2c input clock definition in drivers/mfd/intel-lpss-pci.c is also wrong for Apollo Lake (N3450) ?  There are lots of people having various issues with i2c attached touchpads on Apollo Lake

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

2018-05-18 Thread Hans de Goede
Hi, On 18-05-18 15:15, Jarkko Nikula wrote: On 05/18/2018 10:48 AM, Hans de Goede wrote: Could it be the i2c input clock definition in drivers/mfd/intel-lpss-pci.c is also wrong for Apollo Lake (N3450) ?  There are lots of people having various issues with i2c attached touchpads on Apollo Lake

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

2018-05-18 Thread Jarkko Nikula
On 05/18/2018 10:48 AM, Hans de Goede wrote: Could it be the i2c input clock definition in drivers/mfd/intel-lpss-pci.c is also wrong for Apollo Lake (N3450) ?  There are lots of people having various issues with i2c attached touchpads on Apollo Lake devices, this bug: https://bugs.launchpad.ne

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

2018-05-18 Thread Hans de Goede
Hi, On 18-05-18 12:58, Jarkko Nikula wrote: On 05/18/2018 01:20 PM, Andy Shevchenko wrote: On Fri, 2018-05-18 at 11:37 +0300, Andy Shevchenko wrote: On Fri, 2018-05-18 at 09:48 +0200, Hans de Goede wrote: Could it be the i2c input clock definition in drivers/mfd/intel- lpss- pci.c is also w

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

2018-05-18 Thread Jarkko Nikula
On 05/18/2018 01:20 PM, Andy Shevchenko wrote: On Fri, 2018-05-18 at 11:37 +0300, Andy Shevchenko wrote: On Fri, 2018-05-18 at 09:48 +0200, Hans de Goede wrote: Could it be the i2c input clock definition in drivers/mfd/intel- lpss- pci.c is also wrong for Apollo Lake (N3450) ? There are lots

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

2018-05-18 Thread Andy Shevchenko
On Fri, 2018-05-18 at 11:37 +0300, Andy Shevchenko wrote: > On Fri, 2018-05-18 at 09:48 +0200, Hans de Goede wrote: > > > > Could it be the i2c input clock definition in drivers/mfd/intel- > > lpss- > > pci.c > > is also wrong for Apollo Lake (N3450) ? There are lots of people > > having > > var

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

2018-05-18 Thread Andy Shevchenko
On Fri, 2018-05-18 at 09:48 +0200, Hans de Goede wrote: > Could it be the i2c input clock definition in drivers/mfd/intel-lpss- > pci.c > is also wrong for Apollo Lake (N3450) ? There are lots of people > having > various issues with i2c attached touchpads on Apollo Lake devices, > this bug: > h

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

2018-05-18 Thread Hans de Goede
Hi Jarkko, et.al., On 17-05-18 09:48, Jarkko Nikula wrote: Hi On 05/15/2018 01:20 PM, Jarkko Nikula wrote: On 05/15/2018 06:22 AM, Chris Chiu wrote: What if I change the 120MHz to 180MHz and then make sure that the I2C operates in target FS mode frequency 400kHz via scope? Would there be any

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

2018-05-17 Thread Chris Chiu
On Thu, May 17, 2018 at 3:48 PM, Jarkko Nikula wrote: > Hi > > On 05/15/2018 01:20 PM, Jarkko Nikula wrote: >> >> On 05/15/2018 06:22 AM, Chris Chiu wrote: >>> >>> What if I change the 120MHz to 180MHz and then make sure that the I2C >>> operates >>> in target FS mode frequency 400kHz via scope? W

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

2018-05-17 Thread Jarkko Nikula
Hi On 05/15/2018 01:20 PM, Jarkko Nikula wrote: On 05/15/2018 06:22 AM, Chris Chiu wrote: What if I change the 120MHz to 180MHz and then make sure that the I2C operates in target FS mode frequency 400kHz via scope? Would there be any side effect? Maybe some other busses frequency could be also

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

2018-05-15 Thread Jarkko Nikula
On 05/15/2018 06:22 AM, Chris Chiu wrote: What if I change the 120MHz to 180MHz and then make sure that the I2C operates in target FS mode frequency 400kHz via scope? Would there be any side effect? Maybe some other busses frequency could be also affected and causing some other component malfunct

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

2018-05-14 Thread Chris Chiu
On Mon, May 14, 2018 at 10:20 PM, Jarkko Nikula wrote: > On 05/10/2018 03:03 PM, Chris Chiu wrote: >> >> Report from guys who can access scope. If i2c-sda-falling-time-ns=400ns >> , HCNT increase to 117, the SCL high duration is 576ns as follows >> https://pasteboard.co/HkwERvP.png >> >> The origi

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

2018-05-14 Thread Jarkko Nikula
On 05/10/2018 03:03 PM, Chris Chiu wrote: Report from guys who can access scope. If i2c-sda-falling-time-ns=400ns , HCNT increase to 117, the SCL high duration is 576ns as follows https://pasteboard.co/HkwERvP.png The original SCL high duration (HCNT = 105, 120MHz) is as follows https://pasteboa

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

2018-05-10 Thread Chris Chiu
On Tue, May 8, 2018 at 11:47 PM, Daniel Drake wrote: > On Tue, May 8, 2018 at 8:31 AM, Jarkko Nikula > wrote: >>> Some update, we can make the touchpad work by simply modifying the >>> clk_rate of spt_i2c_info from 12000 to 13300 in intel-lpss-pci.c for >>> specific PCI ID 8086:a368 ~ a36

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

2018-05-08 Thread Daniel Drake
On Tue, May 8, 2018 at 8:31 AM, Jarkko Nikula wrote: >> Some update, we can make the touchpad work by simply modifying the >> clk_rate of spt_i2c_info from 12000 to 13300 in intel-lpss-pci.c for >> specific PCI ID 8086:a368 ~ a36a (CoffeeLake). Is the clock setting different >> for the Cof

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

2018-05-08 Thread Jarkko Nikula
Hi On 05/07/2018 11:07 AM, Chris Chiu wrote: Besides, according to ASUS's input, they observed that after entering the OS, the frequency of SCL is too fast (about 600kHz) and the SCL High time is around 450ns, not following I2C spec which is 0.6us. https://pasteboard.co/HjzSWXd.png Some updat

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

2018-05-07 Thread Chris Chiu
On Fri, May 4, 2018 at 2:55 PM, Jian-Hong Pan wrote: > Hi, > > We have an ASUS X580GD (Intel(R) Core(TM) i5-8300H CPU @ 2.30GHz) laptop > equipped with ELAN1200 touchpad which does not work totally, but the > external mouse works fine. > > We have checked the input devices by "cat /proc/bus/input/

[BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

2018-05-03 Thread Jian-Hong Pan
Hi, We have an ASUS X580GD (Intel(R) Core(TM) i5-8300H CPU @ 2.30GHz) laptop equipped with ELAN1200 touchpad which does not work totally, but the external mouse works fine. We have checked the input devices by "cat /proc/bus/input/devices", and the touchpad does not appear in the list. According