Re: [BUG] fs/dcache: might_sleep is called under a spinlock

2017-10-03 Thread Jia-Ju Bai
Thanks for your detailed explanation :) I will improve my static analysis tool. Thanks, Jia-Ju Bai On 2017/10/3 11:19, Al Viro wrote: On Tue, Oct 03, 2017 at 10:38:25AM +0800, Jia-Ju Bai wrote: According to fs/dcache.c, might_sleep is called under a spinlock, and the function call path is: d_

Re: [BUG] fs/dcache: might_sleep is called under a spinlock

2017-10-02 Thread Al Viro
On Tue, Oct 03, 2017 at 10:38:25AM +0800, Jia-Ju Bai wrote: > According to fs/dcache.c, might_sleep is called under a spinlock, > and the function call path is: > d_prune_aliases (acquire the spinlock) > dput > might_sleep > > This bug is found by my static analysis tool and my code review.

[BUG] fs/dcache: might_sleep is called under a spinlock

2017-10-02 Thread Jia-Ju Bai
According to fs/dcache.c, might_sleep is called under a spinlock, and the function call path is: d_prune_aliases (acquire the spinlock) dput might_sleep This bug is found by my static analysis tool and my code review. A possible fix is to remove might_sleep in dput. Thanks, Jia-Ju Bai