Re: [BUG] MODULE_PARM conversions introduces bug in Wavelan driver

2005-01-19 Thread Jean Tourrilhes
On Wed, Jan 19, 2005 at 01:42:33PM +1100, Rusty Russell wrote: > On Tue, 2005-01-18 at 16:47 -0800, Jean Tourrilhes wrote: > > Hi Rusty, > > > > (If you are not the culprit, please forward to the guilty party). > > Almost certainly me. We gave people warning, we even marked MODULE_PARM >

Re: [BUG] MODULE_PARM conversions introduces bug in Wavelan driver

2005-01-18 Thread Rusty Russell
On Tue, 2005-01-18 at 16:47 -0800, Jean Tourrilhes wrote: > Hi Rusty, > > (If you are not the culprit, please forward to the guilty party). Almost certainly me. We gave people warning, we even marked MODULE_PARM deprecated, but eventually I had to roll through and try to autoconvert.

[BUG] MODULE_PARM conversions introduces bug in Wavelan driver

2005-01-18 Thread Jean Tourrilhes
Hi Rusty, (If you are not the culprit, please forward to the guilty party). The patch the the Wavelan driver that I quote below introduces a nice bug that can crash the kernel. Maybe you want to think about fixing it, or maybe I should revert the patch... As a sid