Re: [BUG][PATCH] Fix race condition about network device name allocation

2007-05-14 Thread Stephen Hemminger
On Mon, 14 May 2007 10:33:01 +0900 Kenji Kaneshige <[EMAIL PROTECTED]> wrote: > Hi Stephen, > > Thank you for comments. I'll try your patch. > > I have one concern about your patch, though I don't know very much > about netdev codes. > > @@ -3411,6 +3410,9 @@ void unregister_netdevice(struct n

Re: [BUG][PATCH] Fix race condition about network device name allocation

2007-05-14 Thread Kenji Kaneshige
Hi, > How about the following (untested), instead. It hold a removes the sysfs > entries earlier (on unregister_netdevice), but holds a kobject reference. > Then when todo runs the actual last put free happens. I've confirmed the problem is fixed by Stephen's patch on my reproduction environment.

Re: [BUG][PATCH] Fix race condition about network device name allocation

2007-05-13 Thread Kenji Kaneshige
Hi Stephen, Thank you for comments. I'll try your patch. I have one concern about your patch, though I don't know very much about netdev codes. @@ -3411,6 +3410,9 @@ void unregister_netdevice(struct net_dev > /* Notifier chain MUST detach us from master device. */ > BUG_TRAP(!dev->m

Re: [BUG][PATCH] Fix race condition about network device name allocation

2007-05-11 Thread Stephen Hemminger
On Fri, 11 May 2007 14:40:45 +0900 Kenji Kaneshige <[EMAIL PROTECTED]> wrote: > Hi, > > I encountered the following error when I was hot-plugging network card > using pci hotplug driver. > > kobject_add failed for eth8 with -EEXIST, don't try to register things with > the same name in the same

Re: [BUG][PATCH] Fix race condition about network device name allocation

2007-05-11 Thread Stephen Hemminger
On Fri, 11 May 2007 14:40:45 +0900 Kenji Kaneshige <[EMAIL PROTECTED]> wrote: > Hi, > > I encountered the following error when I was hot-plugging network card > using pci hotplug driver. > > kobject_add failed for eth8 with -EEXIST, don't try to register things with > the same name in the same

[BUG][PATCH] Fix race condition about network device name allocation

2007-05-10 Thread Kenji Kaneshige
Hi, I encountered the following error when I was hot-plugging network card using pci hotplug driver. kobject_add failed for eth8 with -EEXIST, don't try to register things with the same name in the same directory. Call Trace: [] show_stack+0x40/0xa0 sp=e0006