Re: [3.11-rc1] CONFIG_DEBUG_MUTEXES=y using gcc 3.x makes unbootablekernel.

2013-09-24 Thread Tetsuo Handa
Hello, Maarten. Is this patch already queued for 3.12-rcX ? I expect this patch be committed before sending a patch for 3.11-stable. Regards. -- >From a1b01c858143c2c2c92b17e7df096042bfe0df6b Mon Sep 17 00:00:00 2001 From: Tetsuo Handa Date: Tue, 24 Sep 2013 23:44:17 +0900 Subject: [PATC

Re: [3.11-rc1] CONFIG_DEBUG_MUTEXES=y using gcc 3.x makes unbootablekernel.

2013-09-09 Thread Tetsuo Handa
Maarten Lankhorst wrote: > Yeah looks ok, did you run the selftests from > CONFIG_DEBUG_LOCKING_API_SELFTESTS, > with/without CONFIG_PROVE_LOCKING and once more with DEBUG_MUTEXES also unset? Since CONFIG_DEBUG_MUTEXES=n && CONFIG_PROVE_LOCKING=y is impossible, I tested CONFIG_DEBUG_MUTEXES=y

Re: [3.11-rc1] CONFIG_DEBUG_MUTEXES=y using gcc 3.x makes unbootablekernel.

2013-09-09 Thread Peter Zijlstra
On Mon, Sep 09, 2013 at 08:56:53PM +0900, Tetsuo Handa wrote: > From: Tetsuo Handa > Date: Mon, 9 Sep 2013 20:48:13 +0900 > Subject: [PATCH] mutex: Avoid gcc version dependent __builtin_constant_p() > usage. > > Commit 040a0a37 "mutex: Add support for wound/wait style locks" used > "!__builtin_c

Re: [3.11-rc1] CONFIG_DEBUG_MUTEXES=y using gcc 3.x makes unbootablekernel.

2013-09-09 Thread Maarten Lankhorst
Op 09-09-13 13:56, Tetsuo Handa schreef: > Maarten Lankhorst wrote: >> Almost correct. I meant passing it as parameter to __mutex_lock_common. Your >> version will still cause an extra pointless null check in the ww_mutex_lock >> case. > Ah, I see. > -- > >From 95f189eb37c25ddf8e48d5dfc2f

Re: [3.11-rc1] CONFIG_DEBUG_MUTEXES=y using gcc 3.x makes unbootablekernel.

2013-09-09 Thread Tetsuo Handa
Maarten Lankhorst wrote: > Almost correct. I meant passing it as parameter to __mutex_lock_common. Your > version will still cause an extra pointless null check in the ww_mutex_lock > case. Ah, I see. -- >From 95f189eb37c25ddf8e48d5dfc2f9f1185c52b6a8 Mon Sep 17 00:00:00 2001 From: Tetsuo

Re: [3.11-rc1] CONFIG_DEBUG_MUTEXES=y using gcc 3.x makes unbootablekernel.

2013-09-08 Thread Maarten Lankhorst
Op 08-09-13 13:53, Tetsuo Handa schreef: > Hello. > > Maarten Lankhorst wrote: >> if it's broken for your compiler, please add a bool use_ww_ctx or something >> to __mutex_lock_common that's set directly instead, the __builtin_constant_p >> trick >> might be too gcc version specific. > I see. I t

Re: [3.11-rc1] CONFIG_DEBUG_MUTEXES=y using gcc 3.x makes unbootablekernel.

2013-09-08 Thread Tetsuo Handa
Hello. Maarten Lankhorst wrote: > if it's broken for your compiler, please add a bool use_ww_ctx or something > to __mutex_lock_common that's set directly instead, the __builtin_constant_p > trick > might be too gcc version specific. I see. I tested that both gcc 3.x and gcc 4.x can generate bo