[FIX] Re: [2.6 patch] drivers/cdrom/isp16.c: small cleanups

2005-01-30 Thread Al Viro
On Sun, Jan 30, 2005 at 12:54:30AM +0100, Bartlomiej Zolnierkiewicz wrote: > On Sun, 30 Jan 2005 00:46:24 +0100, Adrian Bunk <[EMAIL PROTECTED]> wrote: > > On Sat, Jan 29, 2005 at 06:51:25PM +0100, Bartlomiej Zolnierkiewicz wrote: > > > Hi, > > > > > > On Sat, 29 Jan 2005 18:11:08 +0100, Adrian Bun

Re: [2.6 patch] drivers/cdrom/isp16.c: small cleanups

2005-01-29 Thread Bartlomiej Zolnierkiewicz
On Sun, 30 Jan 2005 00:46:24 +0100, Adrian Bunk <[EMAIL PROTECTED]> wrote: > On Sat, Jan 29, 2005 at 06:51:25PM +0100, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > > > On Sat, 29 Jan 2005 18:11:08 +0100, Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > This patch makes the needlessly global function is

Re: [2.6 patch] drivers/cdrom/isp16.c: small cleanups

2005-01-29 Thread Adrian Bunk
On Sat, Jan 29, 2005 at 06:51:25PM +0100, Bartlomiej Zolnierkiewicz wrote: > Hi, > > On Sat, 29 Jan 2005 18:11:08 +0100, Adrian Bunk <[EMAIL PROTECTED]> wrote: > > This patch makes the needlessly global function isp16_init static. > > > > As a result, it turned out that both this function and som

Re: [2.6 patch] drivers/cdrom/isp16.c: small cleanups

2005-01-29 Thread Bartlomiej Zolnierkiewicz
Hi, On Sat, 29 Jan 2005 18:11:08 +0100, Adrian Bunk <[EMAIL PROTECTED]> wrote: > This patch makes the needlessly global function isp16_init static. > > As a result, it turned out that both this function and some other code > are only required #ifdef MODULE. Your patch is correct but it is wrong.

[2.6 patch] drivers/cdrom/isp16.c: small cleanups

2005-01-29 Thread Adrian Bunk
This patch makes the needlessly global function isp16_init static. As a result, it turned out that both this function and some other code are only required #ifdef MODULE. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/cdrom/isp16.c | 13 - drivers/cdrom/isp16.h |