Re: [v5, 2/2] drivers/watchdog: ASPEED reference dev tree properties for config

2017-08-14 Thread Guenter Roeck
On Mon, Jul 17, 2017 at 02:25:39PM -0500, Christopher Bostic wrote: > Reference the system device tree when configuring the watchdog > engines. If property 'aspeed,reset_type' is present then set > reset behavior based on the specified value. This can be one of > three different mutually exclusive

[PATCH v5 2/2] drivers/watchdog: ASPEED reference dev tree properties for config

2017-07-17 Thread Christopher Bostic
Reference the system device tree when configuring the watchdog engines. If property 'aspeed,reset_type' is present then set reset behavior based on the specified value. This can be one of three different mutually exclusive values * cpu - Reset CPU only on watchdog timeout * soc - Reset System

Re: [v4, 2/2] drivers/watchdog: ASPEED reference dev tree properties for config

2017-07-10 Thread Christopher Bostic
On 7/8/17 9:55 AM, Guenter Roeck wrote: On Thu, Jul 06, 2017 at 07:49:00PM -0500, Christopher Bostic wrote: Reference the system device tree when configuring the watchdog engines. If property 'aspeed,reset_type' is present then set reset behavior based on the specified value. This can be one

Re: [v4, 2/2] drivers/watchdog: ASPEED reference dev tree properties for config

2017-07-08 Thread Guenter Roeck
On Thu, Jul 06, 2017 at 07:49:00PM -0500, Christopher Bostic wrote: > Reference the system device tree when configuring the watchdog > engines. If property 'aspeed,reset_type' is present then set > reset behavior based on the specified value. This can be one of > three different mutually exclusive

[PATCH v4 2/2] drivers/watchdog: ASPEED reference dev tree properties for config

2017-07-06 Thread Christopher Bostic
Reference the system device tree when configuring the watchdog engines. If property 'aspeed,reset_type' is present then set reset behavior based on the specified value. This can be one of three different mutually exclusive values * cpu - Reset CPU only on watchdog timeout * soc - Reset System

[PATCH v3 2/2] drivers/watchdog: ASPEED reference dev tree properties for config

2017-06-28 Thread Christopher Bostic
Reference the system device tree when configuring the watchdog engines. If optional property 'aspeed,no-sys-reset' is specified then override the default config and do not set sys reset mode. If optional property 'aspeed,no-soc-reset' is specified then override the default and do not set soc reset

Re: [PATCH v2 2/2] drivers/watchdog: ASPEED reference dev tree properties for config

2017-06-28 Thread Guenter Roeck
On Wed, Jun 28, 2017 at 11:09:15AM -0500, Christopher Bostic wrote: > > >> > >>Why would there even be a need configure for no system reset? The external > >>mode 'wdt ext: External signal enable after timeout' can be sent off chip > >>even if system reset is disabled. The watchdog is doing some

Re: [PATCH v2 2/2] drivers/watchdog: ASPEED reference dev tree properties for config

2017-06-28 Thread Christopher Bostic
On 6/28/17 11:06 AM, Guenter Roeck wrote: On Wed, Jun 28, 2017 at 10:55:08AM -0500, Christopher Bostic wrote: On 6/28/17 10:08 AM, Guenter Roeck wrote: On Wed, Jun 28, 2017 at 09:59:22AM -0500, Christopher Bostic wrote: On 6/28/17 9:54 AM, Guenter Roeck wrote: On Wed, Jun 28, 2017 at 09:29

Re: [PATCH v2 2/2] drivers/watchdog: ASPEED reference dev tree properties for config

2017-06-28 Thread Guenter Roeck
On Wed, Jun 28, 2017 at 10:55:08AM -0500, Christopher Bostic wrote: > > > On 6/28/17 10:08 AM, Guenter Roeck wrote: > >On Wed, Jun 28, 2017 at 09:59:22AM -0500, Christopher Bostic wrote: > >> > >>On 6/28/17 9:54 AM, Guenter Roeck wrote: > >>>On Wed, Jun 28, 2017 at 09:29:50AM -0500, Christopher B

Re: [PATCH v2 2/2] drivers/watchdog: ASPEED reference dev tree properties for config

2017-06-28 Thread Christopher Bostic
On 6/28/17 10:08 AM, Guenter Roeck wrote: On Wed, Jun 28, 2017 at 09:59:22AM -0500, Christopher Bostic wrote: On 6/28/17 9:54 AM, Guenter Roeck wrote: On Wed, Jun 28, 2017 at 09:29:50AM -0500, Christopher Bostic wrote: On 6/28/17 6:31 AM, Guenter Roeck wrote: On 06/27/2017 02:17 PM, Christ

Re: [PATCH v2 2/2] drivers/watchdog: ASPEED reference dev tree properties for config

2017-06-28 Thread Guenter Roeck
On Wed, Jun 28, 2017 at 09:59:22AM -0500, Christopher Bostic wrote: > > > On 6/28/17 9:54 AM, Guenter Roeck wrote: > >On Wed, Jun 28, 2017 at 09:29:50AM -0500, Christopher Bostic wrote: > >> > >>On 6/28/17 6:31 AM, Guenter Roeck wrote: > >>>On 06/27/2017 02:17 PM, Christopher Bostic wrote: >

Re: [PATCH v2 2/2] drivers/watchdog: ASPEED reference dev tree properties for config

2017-06-28 Thread Christopher Bostic
On 6/28/17 9:54 AM, Guenter Roeck wrote: On Wed, Jun 28, 2017 at 09:29:50AM -0500, Christopher Bostic wrote: On 6/28/17 6:31 AM, Guenter Roeck wrote: On 06/27/2017 02:17 PM, Christopher Bostic wrote: Reference the system device tree when configuring the watchdog engines. Set external signa

Re: [PATCH v2 2/2] drivers/watchdog: ASPEED reference dev tree properties for config

2017-06-28 Thread Guenter Roeck
On Wed, Jun 28, 2017 at 09:29:50AM -0500, Christopher Bostic wrote: > > > On 6/28/17 6:31 AM, Guenter Roeck wrote: > >On 06/27/2017 02:17 PM, Christopher Bostic wrote: > >>Reference the system device tree when configuring the watchdog > >>engines. Set external signal mode on timeout if specified

Re: [PATCH v2 2/2] drivers/watchdog: ASPEED reference dev tree properties for config

2017-06-28 Thread Christopher Bostic
On 6/28/17 6:31 AM, Guenter Roeck wrote: On 06/27/2017 02:17 PM, Christopher Bostic wrote: Reference the system device tree when configuring the watchdog engines. Set external signal mode on timeout if specified. Set system reset on timeout if specified. Signed-off-by: Christopher Bostic --

Re: [PATCH v2 2/2] drivers/watchdog: ASPEED reference dev tree properties for config

2017-06-28 Thread Guenter Roeck
On 06/27/2017 02:17 PM, Christopher Bostic wrote: Reference the system device tree when configuring the watchdog engines. Set external signal mode on timeout if specified. Set system reset on timeout if specified. Signed-off-by: Christopher Bostic --- v2 - Change of_get_property() to of_proper

[PATCH v2 2/2] drivers/watchdog: ASPEED reference dev tree properties for config

2017-06-27 Thread Christopher Bostic
Reference the system device tree when configuring the watchdog engines. Set external signal mode on timeout if specified. Set system reset on timeout if specified. Signed-off-by: Christopher Bostic --- v2 - Change of_get_property() to of_property_read_bool() - Remove redundant check for NULL

Re: [2/2] drivers/watchdog: ASPEED reference dev tree properties for config

2017-06-26 Thread Christopher Bostic
On 6/24/17 5:17 PM, Guenter Roeck wrote: On Tue, Jun 13, 2017 at 03:38:18PM -0500, Christopher Bostic wrote: Reference the system device tree when configuring the watchdog. Configure for external signal generation if optional attribute 'external-signal' is present in device tree. Configure fo

Re: [2/2] drivers/watchdog: ASPEED reference dev tree properties for config

2017-06-24 Thread Guenter Roeck
On Tue, Jun 13, 2017 at 03:38:18PM -0500, Christopher Bostic wrote: > Reference the system device tree when configuring the watchdog. > Configure for external signal generation if optional attribute > 'external-signal' is present in device tree. Configure for > reset system after timeout if the op

[PATCH 2/2] drivers/watchdog: ASPEED reference dev tree properties for config

2017-06-13 Thread Christopher Bostic
Reference the system device tree when configuring the watchdog. Configure for external signal generation if optional attribute 'external-signal' is present in device tree. Configure for reset system after timeout if the optional attribute 'no-system-reset' is not present. Disabling system reset m