Re: [2*PATCH] alpha I/O access and mb()

2000-12-10 Thread Abramo Bagnara
Before of all I want to publicly apologize with Richard as never my intention was to exacerbate him. > > On Sun, Dec 10, 2000 at 10:23:20PM +0100, Abramo Bagnara wrote: > > asm/io.h uses out of line function only when CONFIG_ALPHA_GENERIC is > > defined, otherwise it uses (take writel as an exa

Re: [2*PATCH] alpha I/O access and mb()

2000-12-10 Thread Richard Henderson
On Sun, Dec 10, 2000 at 10:23:20PM +0100, Abramo Bagnara wrote: > asm/io.h uses out of line function only when CONFIG_ALPHA_GENERIC is > defined, otherwise it uses (take writel as an example) __raw_writel that > IMHO need to be defined in core_t2.h. Perhaps you should _show_ an actual failure rat

Re: [2*PATCH] alpha I/O access and mb()

2000-12-10 Thread Abramo Bagnara
Richard Henderson wrote: > > On Sun, Dec 10, 2000 at 08:04:07PM +0100, Abramo Bagnara wrote: > > ... the only missing things from core_t2.h are some defines to > > permit to it to work when CONFIG_ALPHA_T2 is defined. > > Have you tried it? I did. It works fine. > > What _is_ defined in asm/c

Re: [2*PATCH] alpha I/O access and mb()

2000-12-10 Thread Richard Henderson
On Sun, Dec 10, 2000 at 08:04:07PM +0100, Abramo Bagnara wrote: > ... the only missing things from core_t2.h are some defines to > permit to it to work when CONFIG_ALPHA_T2 is defined. Have you tried it? I did. It works fine. What _is_ defined in asm/core_t2.h is enough for alpha/lib/io.c to d

Re: [2*PATCH] alpha I/O access and mb()

2000-12-10 Thread Abramo Bagnara
Richard Henderson wrote: > > On Sun, Dec 10, 2000 at 10:40:12AM +0100, Abramo Bagnara wrote: > > And this would be the only core_*.h files where this intention is > > expressed? > > Not at all. See core_lca.h, jensen.h, core_cia.h, core_mcpcia.h. I think you're confusing the issues: the only m

Re: [2*PATCH] alpha I/O access and mb()

2000-12-10 Thread Richard Henderson
On Sun, Dec 10, 2000 at 10:40:12AM +0100, Abramo Bagnara wrote: > And this would be the only core_*.h files where this intention is > expressed? Not at all. See core_lca.h, jensen.h, core_cia.h, core_mcpcia.h. r~ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [2*PATCH] alpha I/O access and mb()

2000-12-10 Thread Abramo Bagnara
Richard Henderson wrote: > > On Sat, Dec 09, 2000 at 09:43:00AM +0100, Abramo Bagnara wrote: > > alpha-mb-2.4.diff add missing defines from core_t2.h for non generic > > kernel (against 2.4.0test11) > > These are not "missing". They are intentionally not present > so that stuff will be done out

Re: [2*PATCH] alpha I/O access and mb()

2000-12-09 Thread Richard Henderson
On Sat, Dec 09, 2000 at 09:43:00AM +0100, Abramo Bagnara wrote: > alpha-mb-2.4.diff add missing defines from core_t2.h for non generic > kernel (against 2.4.0test11) These are not "missing". They are intentionally not present so that stuff will be done out of line. r~ - To unsubscribe from thi

Re: [2*PATCH] alpha I/O access and mb()

2000-12-09 Thread Gérard Roudier
On Sat, 9 Dec 2000, Abramo Bagnara wrote: > Gérard Roudier wrote: > > > > > > Based on that, let me claim that most of blind barriers inserted this way > > are useless (thus sob-optimal) and may band-aid useful barriers that are > > missing. The result is subtle bugs, hidden most of the time,

Re: [2*PATCH] alpha I/O access and mb()

2000-12-09 Thread Abramo Bagnara
Gérard Roudier wrote: > > > Based on that, let me claim that most of blind barriers inserted this way > are useless (thus sob-optimal) and may band-aid useful barriers that are > missing. The result is subtle bugs, hidden most of the time, that we will > have to suffer for decades. > > The only

Re: [2*PATCH] alpha I/O access and mb()

2000-12-09 Thread Gérard Roudier
On Sat, 9 Dec 2000, Abramo Bagnara wrote: > > Here you are two patches: > > alpha-mb-2.2.diff add the missing mb() to the cores that still lack it > (against 2.2.18pre25) > > alpha-mb-2.4.diff add missing defines from core_t2.h for non generic > kernel (against 2.4.0test11) > > Please apply

[2*PATCH] alpha I/O access and mb()

2000-12-09 Thread Abramo Bagnara
Here you are two patches: alpha-mb-2.2.diff add the missing mb() to the cores that still lack it (against 2.2.18pre25) alpha-mb-2.4.diff add missing defines from core_t2.h for non generic kernel (against 2.4.0test11) Please apply on your trees. I've also noted that 2.4 uses mb() after read[bw