Re: [-next] memory hotplug regression

2017-06-01 Thread Michal Hocko
On Thu 01-06-17 08:49:54, Heiko Carstens wrote: > On Wed, May 31, 2017 at 08:24:40AM +0200, Michal Hocko wrote: > > > # cat /sys/devices/system/memory/memory16/valid_zones > > > Normal Movable > > > # echo online_movable > /sys/devices/system/memory/memory16/state > > > # cat /sys/devices/system/me

Re: [-next] memory hotplug regression

2017-05-31 Thread Heiko Carstens
On Wed, May 31, 2017 at 08:24:40AM +0200, Michal Hocko wrote: > > # cat /sys/devices/system/memory/memory16/valid_zones > > Normal Movable > > # echo online_movable > /sys/devices/system/memory/memory16/state > > # cat /sys/devices/system/memory/memory16/valid_zones > > Movable > > # cat /sys/devic

Re: [-next] memory hotplug regression

2017-05-30 Thread Michal Hocko
On Tue 30-05-17 16:55:01, Heiko Carstens wrote: > On Tue, May 30, 2017 at 04:32:47PM +0200, Michal Hocko wrote: > > On Tue 30-05-17 14:37:24, Heiko Carstens wrote: > > > On Tue, May 30, 2017 at 02:18:06PM +0200, Michal Hocko wrote: > > > > > So ZONE_DMA ends within ZONE_NORMAL. This shouldn't be po

Re: [-next] memory hotplug regression

2017-05-30 Thread Heiko Carstens
On Tue, May 30, 2017 at 04:32:47PM +0200, Michal Hocko wrote: > On Tue 30-05-17 14:37:24, Heiko Carstens wrote: > > On Tue, May 30, 2017 at 02:18:06PM +0200, Michal Hocko wrote: > > > > So ZONE_DMA ends within ZONE_NORMAL. This shouldn't be possible, unless > > > > this restriction is gone? > > >

Re: [-next] memory hotplug regression

2017-05-30 Thread Michal Hocko
On Tue 30-05-17 16:55:01, Heiko Carstens wrote: > On Tue, May 30, 2017 at 04:32:47PM +0200, Michal Hocko wrote: > > On Tue 30-05-17 14:37:24, Heiko Carstens wrote: > > > On Tue, May 30, 2017 at 02:18:06PM +0200, Michal Hocko wrote: > > > > > So ZONE_DMA ends within ZONE_NORMAL. This shouldn't be po

Re: [-next] memory hotplug regression

2017-05-30 Thread Michal Hocko
On Tue 30-05-17 14:37:24, Heiko Carstens wrote: > On Tue, May 30, 2017 at 02:18:06PM +0200, Michal Hocko wrote: > > > So ZONE_DMA ends within ZONE_NORMAL. This shouldn't be possible, unless > > > this restriction is gone? > > > > The patch below should help. > > It does fix this specific problem,

Re: [-next] memory hotplug regression

2017-05-30 Thread Heiko Carstens
On Tue, May 30, 2017 at 02:18:06PM +0200, Michal Hocko wrote: > > So ZONE_DMA ends within ZONE_NORMAL. This shouldn't be possible, unless > > this restriction is gone? > > The patch below should help. It does fix this specific problem, but introduces a new one: # echo online_movable > /sys/devic

Re: [-next] memory hotplug regression

2017-05-30 Thread Michal Hocko
On Fri 26-05-17 14:25:09, Heiko Carstens wrote: [...] > 1) With the new code I can generate overlapping zones for ZONE_DMA and > ZONE_NORMAL: > > --- new code: > > DMA [mem 0x-0x7fff] > Normal [mem 0x8000-0x00017fff] > > # cat /sys/devices/s

Re: [-next] memory hotplug regression

2017-05-29 Thread Michal Hocko
On Mon 29-05-17 12:11:28, Heiko Carstens wrote: > On Mon, May 29, 2017 at 10:52:31AM +0200, Michal Hocko wrote: > > > Why is it a problem to change the default for 'online'? As far as I can > > > see > > > that doesn't have too much to do with the order of zones, no? > > > > `online' (aka MMOP_ON

Re: [-next] memory hotplug regression

2017-05-29 Thread Heiko Carstens
On Mon, May 29, 2017 at 10:52:31AM +0200, Michal Hocko wrote: > > Why is it a problem to change the default for 'online'? As far as I can see > > that doesn't have too much to do with the order of zones, no? > > `online' (aka MMOP_ONLINE_KEEP) should always inherit its current zone. > The previous

Re: [-next] memory hotplug regression

2017-05-29 Thread Michal Hocko
On Fri 26-05-17 14:25:09, Heiko Carstens wrote: > On Wed, May 24, 2017 at 10:39:57AM +0200, Michal Hocko wrote: > > On Wed 24-05-17 10:20:22, Heiko Carstens wrote: > > > Having the ZONE_MOVABLE default was actually the only point why s390's > > > arch_add_memory() was rather complex compared to oth

Re: [-next] memory hotplug regression

2017-05-26 Thread Heiko Carstens
On Wed, May 24, 2017 at 10:39:57AM +0200, Michal Hocko wrote: > On Wed 24-05-17 10:20:22, Heiko Carstens wrote: > > Having the ZONE_MOVABLE default was actually the only point why s390's > > arch_add_memory() was rather complex compared to other architectures. > > > > We always had this behaviour,

Re: [-next] memory hotplug regression

2017-05-24 Thread Michal Hocko
On Wed 24-05-17 10:20:22, Heiko Carstens wrote: > Hello Michal, > > I just re-tested linux-next with respect to your memory hotplug changes and > actually (finally) figured out that your patch ("mm, memory_hotplug: do not > associate hotadded memory to zones until online)" changes behaviour on > s

[-next] memory hotplug regression

2017-05-24 Thread Heiko Carstens
Hello Michal, I just re-tested linux-next with respect to your memory hotplug changes and actually (finally) figured out that your patch ("mm, memory_hotplug: do not associate hotadded memory to zones until online)" changes behaviour on s390: before your patch memory blocks that were offline and