Re: [-mm patch] make drivers/misc/thinkpad_acpi:fan_mutex static

2007-04-28 Thread Henrique de Moraes Holschuh
On Sun, 29 Apr 2007, Adrian Bunk wrote: > Forward declarations of static functions (if required) and actual > variables (like fan_mutex) belong into the C file, not the header. Very well. I will fix the mess for 2.6.23, or, time permitting, 2.6.22. > > Maybe I should just break the driver into

Re: [-mm patch] make drivers/misc/thinkpad_acpi:fan_mutex static

2007-04-28 Thread Adrian Bunk
On Sat, Apr 28, 2007 at 04:58:21PM -0300, Henrique de Moraes Holschuh wrote: > On Sat, 28 Apr 2007, Adrian Bunk wrote: >... > > BTW: Prototypes for static versions and static variables in a header > > file are really wrong, but the mess is bigger than what I'm > > willing to clean up... >

Re: [-mm patch] make drivers/misc/thinkpad_acpi:fan_mutex static

2007-04-28 Thread Len Brown
> > This patch makes the needlessly global fan_mutex static. applied. thanks, -Len - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at htt

Re: [-mm patch] make drivers/misc/thinkpad_acpi:fan_mutex static

2007-04-28 Thread Henrique de Moraes Holschuh
On Sat, 28 Apr 2007, Adrian Bunk wrote: > On Wed, Apr 25, 2007 at 10:57:16PM -0700, Andrew Morton wrote: > >... > > Changes since 2.6.21-rc7-mm1: > >... > > git-acpi.patch > >... > > git trees > >... > > > This patch makes the needlessly global fan_mutex static. > > Signed-off-by: Adrian Bunk

[-mm patch] make drivers/misc/thinkpad_acpi:fan_mutex static

2007-04-28 Thread Adrian Bunk
On Wed, Apr 25, 2007 at 10:57:16PM -0700, Andrew Morton wrote: >... > Changes since 2.6.21-rc7-mm1: >... > git-acpi.patch >... > git trees >... This patch makes the needlessly global fan_mutex static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- BTW: Prototypes for static versions and