Re: [-mm patch] drivers/ide/pci/tc86c001.c: make a function static

Hello. Adrian Bunk wrote: This patch makes the needlessly global init_hwif_tc86c001() static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> If this patch hasn't been accepted by Andrew yet, could you add another fixlet: init_chipset_tc86c001() should've been __devinit. If not or it's

Re: [-mm patch] drivers/ide/pci/tc86c001.c: make a function static

Hello. Adrian Bunk wrote: +toshiba-tc86c001-ide-driver-take-2.patch This patch makes the needlessly global init_hwif_tc86c001() static. Duh, I hoped tha this driver may get into 2.6.20-rc1 and finally overlooked this. Sigh, uou won't believe how much time this driver rewrite spent in

Re: [-mm patch] drivers/ide/pci/tc86c001.c: make a function static

> I'm not sure whether it'd be a good idea to include such a driver for > the legacy IDE subsystem without a libata based driver for the same > hardware. It would be nice to have a libata driver but having the hardware supported is far better than no support at all. - To unsubscribe from this li

[-mm patch] drivers/ide/pci/tc86c001.c: make a function static

On Thu, Dec 14, 2006 at 10:59:13PM -0800, Andrew Morton wrote: >... > Changes since 2.6.19-mm1: >... > +toshiba-tc86c001-ide-driver-take-2.patch >... > Misc. >... This patch makes the needlessly global init_hwif_tc86c001() static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- BTW: I'm not