Re: [-mm Patch] uml: fix a building error

2008-01-17 Thread Jeff Dike
On Thu, Jan 17, 2008 at 03:17:38PM -0800, Pallipadi, Venkatesh wrote: > >#define X X > > > >is a no-op, yes? > > > > Later there is code in generic.h which is doing > #ifndef ioremap_wc > #define ioremap_wc ioremap_nocache > #endif Ah, that makes a bit more sense. It'd be nice if there was less

RE: [-mm Patch] uml: fix a building error

2008-01-17 Thread Pallipadi, Venkatesh
PROTECTED]; Ingo Molnar; Thomas Gleixner >Subject: Re: [-mm Patch] uml: fix a building error > >On Thu, Jan 17, 2008 at 01:41:50PM -0800, Venki Pallipadi wrote: >> > And while we're on the subject, what's the deal with these, in >> > include/asm-x86/io.h? >> >

Re: [-mm Patch] uml: fix a building error

2008-01-17 Thread Jeff Dike
On Thu, Jan 17, 2008 at 01:41:50PM -0800, Venki Pallipadi wrote: > > And while we're on the subject, what's the deal with these, in > > include/asm-x86/io.h? > > > > #define ioremap_wc ioremap_wc > > #define unxlate_dev_mem_ptr unxlate_dev_mem_ptr > > > > If archs want to override the defaults f

Re: [-mm Patch] uml: fix a building error

2008-01-17 Thread Venki Pallipadi
On Thu, Jan 17, 2008 at 04:14:37PM -0500, Jeff Dike wrote: > On Thu, Jan 17, 2008 at 11:38:53AM -0800, Pallipadi, Venkatesh wrote: > > Apart from unxlate, there is also ioremap_wc which is defined in the > > same way. > > And while we're on the subject, what's the deal with these, in > include/asm

Re: [-mm Patch] uml: fix a building error

2008-01-17 Thread Jeff Dike
On Thu, Jan 17, 2008 at 11:38:53AM -0800, Pallipadi, Venkatesh wrote: > Apart from unxlate, there is also ioremap_wc which is defined in the > same way. And while we're on the subject, what's the deal with these, in include/asm-x86/io.h? #define ioremap_wc ioremap_wc #define unxlate_dev_mem_ptr u

Re: [-mm Patch] uml: fix a building error

2008-01-17 Thread Mariusz Kozlowski
Hello, > >> > This patch fixes this building error: > >> > ... > >> > drivers/char/mem.c: In function 'read_mem': > >> > drivers/char/mem.c:136: error: implicit declaration of > >function 'unxlate_dev_mem_ptr' > >> > ... > >> > >> I see this on sparc64 as well: > >> > >> CC drivers/char/

Re: [-mm Patch] uml: fix a building error

2008-01-17 Thread Andrew Morton
gt;Cc: WANG Cong; linux-kernel@vger.kernel.org; Jeff Dike; > >[EMAIL PROTECTED]; David Miller; > >[EMAIL PROTECTED]; Ingo Molnar; Thomas Gleixner; > >Pallipadi, Venkatesh > >Subject: Re: [-mm Patch] uml: fix a building error > > > >On Thu, 17 Jan 2008 19:11:13

RE: [-mm Patch] uml: fix a building error

2008-01-17 Thread Pallipadi, Venkatesh
lnar; Thomas Gleixner; >Pallipadi, Venkatesh >Subject: Re: [-mm Patch] uml: fix a building error > >On Thu, 17 Jan 2008 19:11:13 +0100 Mariusz Kozlowski ><[EMAIL PROTECTED]> wrote: > >> Hello, >> >> > This patch fixes this building error: >> > ... &

Re: [-mm Patch] uml: fix a building error

2008-01-17 Thread Jeff Dike
On Thu, Jan 17, 2008 at 07:11:13PM +0100, Mariusz Kozlowski wrote: > I see this on sparc64 as well: > > CC drivers/char/mem.o > drivers/char/mem.c: In function 'read_mem': > drivers/char/mem.c:136: error: implicit declaration of function > 'unxlate_dev_mem_ptr' > make[2]: *** [drivers/char

Re: [-mm Patch] uml: fix a building error

2008-01-17 Thread Andrew Morton
On Thu, 17 Jan 2008 19:11:13 +0100 Mariusz Kozlowski <[EMAIL PROTECTED]> wrote: > Hello, > > > This patch fixes this building error: > > ... > > drivers/char/mem.c: In function ‘read_mem’: > > drivers/char/mem.c:136: error: implicit declaration of function > > ‘unxlate_dev_mem_ptr’ > > ... > >

Re: [-mm Patch] uml: fix a building error

2008-01-17 Thread Mariusz Kozlowski
Hello, > This patch fixes this building error: > ... > drivers/char/mem.c: In function ‘read_mem’: > drivers/char/mem.c:136: error: implicit declaration of function > ‘unxlate_dev_mem_ptr’ > ... I see this on sparc64 as well: CC drivers/char/mem.o drivers/char/mem.c: In function 'read_me

Re: [-mm Patch] UML: fix a building error

2008-01-17 Thread Jeff Dike
On Thu, Jan 17, 2008 at 09:21:08PM +0800, WANG Cong wrote: > Building uml failed in current -mm tree. ;( > > The below patch fixes this building error: > ... > include/asm/arch/system.h:8:22: error: asm/nops.h: No such file or directory > ... > > Cc: Jeff Dike <[EMAIL PROTECTED]> > Signed-off-by:

Re: [-mm Patch] uml: fix a building error

2008-01-17 Thread Jeff Dike
On Thu, Jan 17, 2008 at 09:56:41PM +0800, WANG Cong wrote: > > This patch fixes this building error: > ... > drivers/char/mem.c: In function ‘read_mem’: > drivers/char/mem.c:136: error: implicit declaration of function > ‘unxlate_dev_mem_ptr’ > ... > > Cc: Jeff Dike <[EMAIL PROTECTED]> > Signed-

[-mm Patch] uml: fix a building error

2008-01-17 Thread WANG Cong
This patch fixes this building error: ... drivers/char/mem.c: In function ‘read_mem’: drivers/char/mem.c:136: error: implicit declaration of function ‘unxlate_dev_mem_ptr’ ... Cc: Jeff Dike <[EMAIL PROTECTED]> Signed-off-by: WANG Cong <[EMAIL PROTECTED]> --- Index: linux/include/asm-um/io.h ==

[-mm Patch] UML: fix a building error

2008-01-17 Thread WANG Cong
On Thu, Jan 17, 2008 at 02:35:14AM -0800, Andrew Morton wrote: > >ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc8/2.6.24-rc8-mm1/ > Hi, Andrew! Building uml failed in current -mm tree. ;( The below patch fixes this building error: ... include/asm/arch/system.h:8:22: erro