Re: [-mm PATCH 4/7] Memory controller memory accounting

2007-07-05 Thread Balbir Singh
Vaidyanathan Srinivasan wrote: >> >> +if (mem_container_charge(page, mm)) { > > Minor correction. The above line should be > > if (mem_container_charge(new, mm)) { > > to avoid compilation error. > > --Vaidy > > [snip] Thanks, Vaidy, Patch incorporated. -- Warm Regards,

Re: [-mm PATCH 4/7] Memory controller memory accounting

2007-07-05 Thread Vaidyanathan Srinivasan
Balbir Singh wrote: > Add the accounting hooks. The accounting is carried out for RSS and Page > Cache (unmapped) pages. There is now a common limit and accounting for both. > The RSS accounting is accounted at page_add_*_rmap() and page_remove_rmap() > time. Page cache is accounted at add_to_pag

[-mm PATCH 4/7] Memory controller memory accounting

2007-07-04 Thread Balbir Singh
Add the accounting hooks. The accounting is carried out for RSS and Page Cache (unmapped) pages. There is now a common limit and accounting for both. The RSS accounting is accounted at page_add_*_rmap() and page_remove_rmap() time. Page cache is accounted at add_to_page_cache(), __delete_from_page