Re: [-mm PATCH] sysdev_unregister() should call kobject_del()

2008-02-08 Thread Greg KH
On Fri, Feb 08, 2008 at 03:22:29PM -0800, Badari Pulavarty wrote: > > On Thu, 2008-02-07 at 20:55 -0800, Greg KH wrote: > > On Thu, Feb 07, 2008 at 05:25:46PM -0800, Badari Pulavarty wrote: > > > On Thu, 2008-02-07 at 16:38 -0800, Greg KH wrote: > > > > On Thu, Feb 07, 2008 at 03:56:58PM -0800, Ba

Re: [-mm PATCH] sysdev_unregister() should call kobject_del()

2008-02-08 Thread Badari Pulavarty
On Thu, 2008-02-07 at 20:55 -0800, Greg KH wrote: > On Thu, Feb 07, 2008 at 05:25:46PM -0800, Badari Pulavarty wrote: > > On Thu, 2008-02-07 at 16:38 -0800, Greg KH wrote: > > > On Thu, Feb 07, 2008 at 03:56:58PM -0800, Badari Pulavarty wrote: > > > > Hi Greg, > > > > > > > > While playing with h

Re: [-mm PATCH] sysdev_unregister() should call kobject_del()

2008-02-08 Thread Dave Hansen
On Fri, 2008-02-08 at 08:42 -0800, Badari Pulavarty wrote: > > I can add remove link before unregister() as you suggested. > > Regarding accessing kobject after freeing up, no one calls with > "root". > Why not clean it up first, like this ? > > Dave, are you okay with this ? Yeah, I don't see

Re: [-mm PATCH] sysdev_unregister() should call kobject_del()

2008-02-08 Thread Badari Pulavarty
On Thu, 2008-02-07 at 21:41 -0800, Greg KH wrote: > On Thu, Feb 07, 2008 at 09:08:42PM -0800, Badari Pulavarty wrote: > > > > On Thu, 2008-02-07 at 20:55 -0800, Greg KH wrote: > > > On Thu, Feb 07, 2008 at 05:25:46PM -0800, Badari Pulavarty wrote: > > > > On Thu, 2008-02-07 at 16:38 -0800, Greg KH

Re: [-mm PATCH] sysdev_unregister() should call kobject_del()

2008-02-07 Thread Greg KH
On Thu, Feb 07, 2008 at 09:08:42PM -0800, Badari Pulavarty wrote: > > On Thu, 2008-02-07 at 20:55 -0800, Greg KH wrote: > > On Thu, Feb 07, 2008 at 05:25:46PM -0800, Badari Pulavarty wrote: > > > On Thu, 2008-02-07 at 16:38 -0800, Greg KH wrote: > > > > On Thu, Feb 07, 2008 at 03:56:58PM -0800, Ba

Re: [-mm PATCH] sysdev_unregister() should call kobject_del()

2008-02-07 Thread Badari Pulavarty
On Thu, 2008-02-07 at 20:55 -0800, Greg KH wrote: > On Thu, Feb 07, 2008 at 05:25:46PM -0800, Badari Pulavarty wrote: > > On Thu, 2008-02-07 at 16:38 -0800, Greg KH wrote: > > > On Thu, Feb 07, 2008 at 03:56:58PM -0800, Badari Pulavarty wrote: > > > > Hi Greg, > > > > > > > > While playing with h

Re: [-mm PATCH] sysdev_unregister() should call kobject_del()

2008-02-07 Thread Greg KH
On Thu, Feb 07, 2008 at 05:25:46PM -0800, Badari Pulavarty wrote: > On Thu, 2008-02-07 at 16:38 -0800, Greg KH wrote: > > On Thu, Feb 07, 2008 at 03:56:58PM -0800, Badari Pulavarty wrote: > > > Hi Greg, > > > > > > While playing with hotplug memory remove on 2.6.24-mm1, I > > > noticed that /sysf

Re: [-mm PATCH] sysdev_unregister() should call kobject_del()

2008-02-07 Thread Badari Pulavarty
On Thu, 2008-02-07 at 16:38 -0800, Greg KH wrote: > On Thu, Feb 07, 2008 at 03:56:58PM -0800, Badari Pulavarty wrote: > > Hi Greg, > > > > While playing with hotplug memory remove on 2.6.24-mm1, I > > noticed that /sysfs directory entries are not getting removed. > > > > sysdev_unregister() used

Re: [-mm PATCH] sysdev_unregister() should call kobject_del()

2008-02-07 Thread Greg KH
On Thu, Feb 07, 2008 at 03:56:58PM -0800, Badari Pulavarty wrote: > Hi Greg, > > While playing with hotplug memory remove on 2.6.24-mm1, I > noticed that /sysfs directory entries are not getting removed. > > sysdev_unregister() used to call kobject_unregister(). > But in 2.6.24-mm1, its only dro

[-mm PATCH] sysdev_unregister() should call kobject_del()

2008-02-07 Thread Badari Pulavarty
Hi Greg, While playing with hotplug memory remove on 2.6.24-mm1, I noticed that /sysfs directory entries are not getting removed. sysdev_unregister() used to call kobject_unregister(). But in 2.6.24-mm1, its only dropping the ref. It should call kobject_del() to remove the object. Correct ? Wit